Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #29620 Newly added file-diff comment disappears when we switch diff mode
    Actions
    Infos
    #29620
    Thomas Gorka (tgorka)
    2022-11-23 16:36
    2022-11-23 10:38
    31217
    Details
    Newly added file-diff comment disappears when we switch diff mode

    How to reproduce:

    1. - In side-by-side or unidiff mode, add a new comment on a given line
    2. - Switch to the other diff mode

    --> The comment is not displayed

     

    The reason is that when the comment is created, it is added in a store of comments/replies, but it is never added in the list of root comments. When we switch modes, the root comments are retrieved from this store and displayed in the editor instead of being reloaded from REST. If the created comment is not added in this list, it therefore won't be displayed.

    Pull Request
    14.1
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gorka (tgorka)
    Closed
    2022-11-23
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #29213 Tuleap Releases 14.3 Delivered 2022-12-08 10:41 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #29620

    Git commit

    tuleap/tuleap/stable

    request #29620 Newly added file-diff comment disappears when we switch diff mode d8650f77bb
    User avatar Thomas Gorka (tgorka) , 2022-11-23 10:30
    Merge commit 'refs/changes/85/27285/1' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD a940b07a02
    User avatar Marie Ange Garnier (marieange) , 2022-11-23 12:03
    New global comment is displayed twice when added a9a9dc05ac
    User avatar Marie Ange Garnier (marieange) , 2022-11-23 14:06
    Referenced by request #29620

    Artifact Tracker v5

    rel #29213 14.3

    Other

    gerrit #27285
    gerrit #27290
    Display settings

    Follow-ups

    User avatar
    Thomas Gorka (tgorka)2022-11-23 10:41

    gerrit #27285 is under review and should close this request

    • Status changed from Under implementation to Under review
    • Reported in version changed from 14.2 to 14.1