Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #35828 Crash when handling a malformed PR cross ref
    Actions
    Infos
    #35828
    Thomas Gerbet (tgerbet)
    2024-01-05 15:11
    2024-01-05 10:07
    37430
    Details
    Crash when handling a malformed PR cross ref

    Put pr # a (without the space) in a field transforming the cross references (e.g. a tracker text field) to reproduce the crash.

    Trace:

    PHP Fatal error:  Uncaught TypeError: Tuleap\PullRequest\PullRequestRetriever::getPullRequestById(): Argument #1 ($id) must be of type int, string given, called in /usr/share/tuleap/plugins/pullrequest/include/PullRequest/Reference/ReferenceFactory.php on line 39 and defined in /usr/share/tuleap/plugins/pullrequest/include/PullRequest/PullRequestRetriever.php:39
Stack trace:
#0 /usr/share/tuleap/plugins/pullrequest/include/PullRequest/Reference/ReferenceFactory.php(39): Tuleap\PullRequest\PullRequestRetriever->getPullRequestById()
#1 /usr/share/tuleap/plugins/pullrequest/include/pullrequestPlugin.php(372): Tuleap\PullRequest\Reference\ReferenceFactory->getReferenceByPullRequestId()
#2 /usr/share/tuleap/src/common/Event/EventManager.class.php(128): pullrequestPlugin->getReference()
#3 /usr/share/tuleap/src/common/Plugin/PluginLoader.php(73): EventManager->eventManagerDispatch()
    Pull Request
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2024-01-05
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #35497 Tuleap Releases 15.5 Delivered 2024-02-05 12:01 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #35828

    Git commit

    tuleap/tuleap/stable

    Fixes request #35828: Crash when handling a malformed PR cross ref c8b8110b51
    User avatar Thomas Gerbet (tgerbet) , 2024-01-05 10:11
    Referenced by request #35828

    Artifact Tracker v5

    rel #35497 15.5

    Other

    gerrit #30148
    Display settings

    Follow-ups

    User avatar
    Yannis ROSSETTO (rossettoy)2024-01-05 15:11

    Integrated into Tuleap 15.4.99.23

    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2024-01-05