Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #43348 Do not crash when creating or updating widgets with incorrect parameters
    Actions
    Infos
    #43348
    Thomas Gerbet (tgerbet)
    2025-06-10 15:52
    2025-06-09 16:43
    45030
    Details
    Do not crash when creating or updating widgets with incorrect parameters

    Reproduction scenario:

    1. Go to GET /widgets/?action=edit-widget

    Trace:

     Fatal error: Uncaught TypeError: Tuleap\Dashboard\Widget\PreferencesController::checkCSRF(): Argument #1 ($row) must be of type array, bool given, called in /usr/share/tuleap/src/common/Dashboard/Widget/PreferencesController.php on line 77 and defined in /usr/share/tuleap/src/common/Dashboard/Widget/PreferencesController.php:141
Stack trace:
#0 /usr/share/tuleap/src/common/Dashboard/Widget/PreferencesController.php(77): Tuleap\Dashboard\Widget\PreferencesController->checkCSRF()
#1 /usr/share/tuleap/src/common/Dashboard/Widget/Router.php(69): Tuleap\Dashboard\Widget\PreferencesController->update()
#2 /usr/share/tuleap/src/www/widgets/index.php(59): Tuleap\Dashboard\Widget\Router->route()
#3 {main} thrown in /usr/share/tuleap/src/common/Dashboard/Widget/PreferencesController.php on line 141
    Dashboard & Widgets
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2025-06-10
    Attachments
    Empty
    References
    Referencing request #43348

    Git commit

    tuleap/tuleap/stable

    fix: request #43348 Do not crash when creating or updating widgets with incorrect parameters e920d201bc
    User avatar Thomas Gerbet (tgerbet) , 2025-06-10 15:10
    Merge commit 'refs/changes/27/34627/2' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 54f25132ad
    User avatar Kevin Traini (ktraini) , 2025-06-10 15:51
    fix: Quick widget add in kanban/tracker reports do not work 9646e79b5c
    User avatar Thomas Gerbet (tgerbet) , 2025-06-11 16:16
    Display settings

    Follow-ups