•  
      request #43349 Do not crash when accessing the password reset form with invalid parameter
    Infos
    #43349
    Thomas Gerbet (tgerbet)
    2025-06-10 14:12
    2025-06-09 18:07
    45031
    Details
    Do not crash when accessing the password reset form with invalid parameter

    Reproduction scenario:

    1. Go to GET /account/lostlogin.php?confirm_hash[]=a

    Trace:

    Fatal error: Uncaught TypeError: Tuleap\Cryptography\ConcealedString::__construct(): Argument #1 ($value) must be of type string, array given, called in /usr/share/tuleap/src/common/User/Account/LostPassword/DisplayResetPasswordController.php on line 58 and defined in /usr/share/tuleap/src/common/Cryptography/ConcealedString.php:32
    Stack trace:
    #0 /usr/share/tuleap/src/common/User/Account/LostPassword/DisplayResetPasswordController.php(58): Tuleap\Cryptography\ConcealedString->__construct()
    #1 /usr/share/tuleap/src/common/Request/FrontRouter.php(241): Tuleap\User\Account\LostPassword\DisplayResetPasswordController->process()
    #2 /usr/share/tuleap/src/common/Request/FrontRouter.php(98): Tuleap\Request\FrontRouter->routeHandler()
    #3 /usr/share/tuleap/src/www/index.php(50): Tuleap\Request\FrontRouter->route() #4 {main} thrown in /usr/share/tuleap/src/common/Cryptography/ConcealedString.php on line 32
    

    This issue is likely present in multiple places in Tuleap but this endpoint is always tested during audits, I mostly want to avoid false positives.

    Authentication & LDAP
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2025-06-10
    Attachments
    Empty
    References

    Follow-ups