•  
      request #7263 Display the list of TV5 trackers pending for deletion
    Infos
    #7263
    Ahmed HOSNI (hosniah)
    2016-08-05 11:55
    2014-07-24 10:03
    7271
    Details
    Display the list of TV5 trackers pending for deletion
    As a Tuleap site admin i need to retrieve the liste of deleted tracker V5.
    Empty
    Empty
    Empty
    • [x] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Ahmed HOSNI (hosniah)
    Closed
    2016-08-05
    Attachments
    Empty
    References

    Follow-ups

    User avatar

    The two years old gerrit #2831 has just been integrated into Tuleap 8.17.99.54


    Thanks for your contribution!


    • Status changed from Under implementation to Closed
    • Close date set to 2016-08-05
    User avatar
    Ahmed HOSNI (hosniah)2016-07-27 12:11

    Hello Nicolas,

    Sorry for this late answer, i was stuck in some endless tasks.

    I do agree your proposal, i'll update the current change like below:

    - i'll remove the delete part  to make it ready for integration ( IT should also match this CR subject)

    - Rgiht after i'll open another CR  dedicated for the deletion part (i'll try to summerize some the important reviews items you gave during last monthes in this tickets) and push the separated deletion part. 

    User avatar
    Hi @hosniah,

    In order to go ahead on this subject, may I suggest to split this request? From what I've seen in the review, we could merge :
    - The display of deleted trackers in site admin area
    - The ability to restore a given tracker

    This will decrease the size of the review, and I don't see any blockers to merge it. The deletion part is a bigger problem that we can address afterwards.

    How do you feel about this?
    User avatar
    I deleted a tracker today and after that I noticed that when I go to "Trackers administration --> Pending trackers removal" as the site admin I do not see any trackers in the list - it just displays: "No Tracker pending for Deletion".

    But I have an even bigger problem with the cross references. After I removed the tracker all cross references to it still remained in the other trackers...

    I am currently still using Tuleap v8.6.
    User avatar
    The difficulty I see is the "minimum consistency".

    As of today, AFAIK, the delete let the database in a consistent state.
    If we start to have a part of the data that are no longer reachable, it will clutter the database with un wanted (and un needed) values.

    Maybe an intermediate state would be to completely hide the feature until the work is completed.
    User avatar
    Ahmed HOSNI (hosniah)2015-06-18 11:51
    Hello Manuel,

    You are right, it has been under review since a very long time (There is always an interruption here, it's hard to concentrate on dev).

    The tricky part with this change is how to cascade the deletion of a tracker to all related concepts (without MySQL Foreign Key Constraints reference):

    It has been done for fields, permissions, workflow, transitions and artifacts. I've just also removed shared fields links as recommended by Nicolas.
    However values are not yet deleted, i just kept the default behavior when permanently deleting a form element, implemented within Tracker_FormElementFactory::deleteFormElement($form_element_id).

    I'm not sure if we could split the change now, but would be really helpful if we manage to merge (if it's mergeable) the current status with minimum database consistency check and deal with missing stuff in other smaller changes.

    Is it possible?
    User avatar
    What are the plans here for this ?

    The patch is 10 months old and the last patch set is pending since 3 weeks. How can we move forward and get this merged ?
    User avatar
    Ahmed HOSNI (hosniah)2015-05-21 13:03
    Hi Tuleap integrators,

    Could you please take a look at this old change #2831?
    i've added a new patchset.

    Regards,
    Ahmed
    User avatar
    Ahmed HOSNI (hosniah)2014-07-24 10:04
    • Status changed from New to Under implementation
    • Assigned to changed from None to Ahmed HOSNI (hosniah)