Integrated in Tuleap 8.0.99.24 and Tuleap 8.0.99.25

see also gerrit #3772

Hi,

Any update please ?

Thanks

Hi,

we have an idea to solve the possible concurrency issue. I'm going to write a changeset on top of yours that will modify things as follows.

1. As codendiadm
2. chgrp gitolite backup.tar.gz -> this changes the group so that gitolite has rights on the file. - use System_Command::exec().
3. As gitolite
4. Untar the file.
5. As codendiadm
6. Update the gitolite config

All this can be done with the owner 'app'.

I will then merge both commits together.

As discussed via chat, the patch is ok but we need to figure something out surrounding concurrent events via the app and root owners of events for the same queue. I'll get back to you.

Your review and feedbacks for http://gerrit.tuleap.net/#/c/3003/ are welcome.

Thank you in advance

Any update please ?

Please review in : http://gerrit.tuleap.net/#/c/3003/

Thank you in advance

It is in our team task. We will reveiw this as sson as possible

Your review and feedbacks for http://gerrit.tuleap.net/#/c/3003/ are welcome.

Thanks

Please review in : http://gerrit.tuleap.net/#/c/3003/

Thank you in advance

Please review in : http://gerrit.tuleap.net/#/c/3003/

Please review in : http://gerrit.tuleap.net/#/c/3003/

The proper way to do it is to have a RESTORE event lauched as root so it can restore the files and run the chown (see BackendSystem for this)
Then, once this RESTORE is done, there should be another even (lauched as APP) to re-update the repo definition (probably just launche GIT_REPO_UPDATE should be enough)

For the RESTORE part, ideally it should be in git queue but as of today there is no way to execute an event of git queue as root. I think the easiest way is to launch it in main/default queue.

We are busy on 7.8 validation, we will have a look at your questions once it's out.

Any idea please ?

Any idea please ?

Any idea ?

Hello ,

I've an issue in this restore feature. In fact I was able to restore repositories with wrong ownership (codendiadm:codendiadm instead of

gitolite:gitolite) , Is there any method inside git plugin that allow me to change repository ownership ?

"chown" command doesn't work due to user permission (codendiadm) is not able to change ownsership.

I've tried to run Restore systemevent with root, but it was blocked to "new" status and when running it with "app" it works well except this

ownership issue.

You could try my code in http://gerrit.tuleap.net/#/c/3003/

Thing that is not clear to me is how tuleap fix right ownership (gitolite:gitolite) when creating repository with system event running with app user

(normally codendiadm) ?
If you look at "/usr/share/tuleap/plugins/git/include/events/SystemEvent_GIT_REPO_UPDATE.class.php" you will see that inside process method

we have one call that seems to be responsible for repo creation wich is :
$repository->getBackend()->updateRepoConf($repository);

In my restore code I've already call this method but it doesn't change the ownership to gitolite:gitolite

Thanks to help
Amin

>>>Does the archived repositories will be automatically purged after a given amount of time like other items?
Yes (it will be announced in other artifact linked to #7363), and in this case we don't need manual deletion from siteadmin interface.

>>>When the repository is archived/restored, what happen on the gerrit server side?
Nothing since the repository should be disconnected from Gerrit before it's deletion .

>>>Something that I did not ask in the previous request:
>>>- Does the user have the choice between archive and delete action or is there only one action archive?
Archiving is automatic after reporitory deletion, so nothing will change from user side, he will have only "delete" button and no other choice.