Those steps sounds good to me, yes you can create a story for each one

Hello Manuel,

What about following decomposition of this feature : 
1-Move sys_disable_subdomains to DB and manage it from configuration panel interface (properties interface will be added)
2-Add allow_underscore param in DB and manage it from properties interface
3-Allow the underscore in project short name and add unit tests

What do you think ? 

Should I create a new story ? 

Thanks 
Amine

I think you are on the good track but you need to go a little bit further.

What you need to do is what we have done when we moved site access control into administration panel (for reference gerrit #3801 and gerrit #3804). That is to say:

• sys_disable_subdomains should be moved inside the DB (forgeconfig table)
• your new parameter will come in the same configuration panel

Then you will have 100% control on the paramters combination

From a UI standpoint, there should be an entry in "Configuration" part (probably near Access Control as it also affects the site at whole)

For the scenario I agree with your proposal (I strongly encourage you to have a good set of unit test to settle the behaviour)

As this might be a large modification, how can you decompose your work so we can review and integrate small parts of it easily ?

Hello Manuel,

I propose the following : 

-Add a checkbox called "allow underscore in project shortname" in "Configuration of predefined services" interface. 
-The value of this checkbox will be stored in database (service table)
-"allow_underscore" could be set to 1 only if : 
     *sys_disable_subdomains is set to 1 in local.inc
     *Home page is disabled
-If "allow_underscore" is set to 1:
   *$GLOBALS['sys_disable_subdomains'] will be set to 1 even if it's 0 in local_inc
   *Home page could not be enabled 
-"allow_underscore" could be set to 0 only if there is no project short name containing underscore

What do you think ?

BR
Amine

I removed the review from WIP queue as no answer since 4 days.

Plus, we should discuss here how you propose to handle this comment:

" You should propose a mechanism to prevent the siteadmin to switch back to use of subdomains or homepages "

Thanks,
Manuel