Add / remove reviewers
After having created a PR, on the PR view, there is a list of reviewers that is empty.
I can click on "Edit" to add people:
Both with auto-completers (I cannot add raw email address)
When people/groups are added they get a notification about the PR to reviews.
It's possible to remove reviewers with the same process.
"Owner" of the PR is automatically part of the notification list. Who is "owner":
- creator of PR
- commit author => NO, we don't want to notify linux kernel contributors
- push author
Notifications
What triggers a notifications
- A new comment (there will be one email per comment) (done in story #14190)
- A new push in the branch (done in story #14190)
- A Jenkins update of the branch
- Being added as a reviewer (only new reviewers are notified, existing reviewers are not notified about add/remove) (done in story #14190)
There is a check of permissions as well as an email de-duplication at sending time to avoid leaking informations.
The code should also respect "Truncated Emails"
Notifications are handled with Backend Workers (Redis) whenever possible to avoid slowdown on push/comment & co.
Content of the notification to be defined
- On reviewer added:
- commit summary (id, shortlog)
- stats (list of files + status)
- link to the PR (done in story #14190)
- On comment: (done in story #14190)
- link to the PR
- comments + context (file, code fragment)
- On push:
- link to the PR (done in story #14190)
- shortlog of modified files (/!\ force push)
- Merge/abandon (done in story #14190)
- link to the PR
- status of PR
- Jenkins
- link to the PR
- CI status (only for the last commit of the PR, only if the CI status change)
- On title/description change? => NO
Bonus: The information of reviewers added/removed is displayed in the PR log