Manuel Vacelet (vaceletm)2019-11-06 15:06 gerrit #16519 integrated into Tuleap 11.7.99.109 Status changed from On going to DoneCategory set to
Manuel Vacelet (vaceletm)2019-10-15 14:24 gerrit #16045 integrated into Tuleap 11.6.99.142 Do not forget to provide patch with a logger so we can have traces of what's happening in the backend
Manuel Vacelet (vaceletm)2019-10-14 13:53 For the record I paste here the 2 images you shared to ensure all data are collected at the same place Attachments image-20191014135137-1.png, image-20191014135201-2.png addedBy Manuel Vacelet (vaceletm)(73 kB)image-20191014135137-1.pngBy Manuel Vacelet (vaceletm)(66 kB)image-20191014135201-2.png
Houssem Eddine Azzouz (heazzouz)2019-10-11 19:57 last edited by: Houssem Eddine Azzouz (heazzouz) 2019-10-14 10:25 I understand your point of vue. But one might argue that it’s more of a functional and subjective choice for system maintainers that it would be useless to try and notify a user that has never used the platform. Plus, and more importantly, the email template of the user story, clearly states that user has last logged in on X day. So, if we are to consider the two cases, we would need to separate the users when sending the emails, that are to be sent with different texts, or use a more generic email. Moreover, concerning thefollowing question: I'm wondering if this query is doing what it's supposed to do. At least in my case, I configured my platform with: sys_suspend_inactive_accounts_delay = 30 sys_suspend_inactive_accounts_notification_delay = 5 I have people with last_access_date before September 16 (today - 30 - 5) and they didn't receive any email. Did I do something wrong in my testing ? you'll find a visual explanation in the following link user story-13810
Manuel Vacelet (vaceletm)2019-10-11 14:02 Hello, I write the comment here because it's about the acceptance criteria. In you comment: After reviewing the query, the conditions aren't the same. The difference between them is that UserDao::suspendInactiveAccounts suspends user who did not login for a certain period and users that did not login at all. The user story specifies that the alert should only be sent to those whould did not login for a certain period. With regards to moving suspendInactiveAccounts to IdleUsersDao, I would prefer to do it in the next related user story. I fail to see where here the acceptance criteria specifies that users that never login shouldn't be notified. And, I really don't understand why they shouldn't be. Could you elaborate ? On a more general approach, I find it odd that the behaviour should be different between the 2 related queries.
Houssem Eddine Azzouz (heazzouz)2019-10-10 18:22 Hello, Could you please review the latest push on gerrit? Thank you.
Manuel Vacelet (vaceletm)2019-10-07 16:44 As already answered in the review, EasyDB prepared statements makes useless escapeInt So that Show diff Switch to markup diff Something went wrong, the follow up content couldn't be loaded Only formatting have been changed, you should switch to markup to see the changes Acceptance criteria Show diff Switch to markup diff Something went wrong, the follow up content couldn't be loaded Only formatting have been changed, you should switch to markup to see the changes
Houssem Eddine Azzouz (heazzouz)2019-09-17 17:00 Hi, I have a of questions (for more contextual information, check the following gerrit push Link). Is there an equivalent to the "escapeInt" function that can be used with the new DAO ?
Nouha Terzi (terzino)2019-08-27 16:27I want to -I would like an automatic notification to be sent to the user 1 or 2 weeks in advance +Have an automatic notification to be sent to the user 1 or 2 weeks in advance before suspension