Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #32316 Update comments
Summary
Empty
Update comments
Empty

I can only update my own comments. Keep time tracking of the comment (date / hour of editing)
Only comment done in markdown are editable.
New REST routes should be created :

  • PATCH pull_request_comments/{id}
  • PATCH pull_request_inline_comments/{id}

Front end :

  • new button
  • edit mode with preview table
  • help button

https://www.figma.com/file/it3BHQkoGPDLTPIV8V6i3h/Git---Pull-requests?type=design&mode=design&t=A7cCmb6XRFTv4WUw-1

Notifications:

  • When comment is saved, a notification is sent (as for new comments)
  • Notification subject: same as new comment
  • Notification message:
$AUTHOR updated their comment on #$PR_ID: $PR_SUMMARY

$NEW_COMMENT
Empty
Empty
Status
Pull Request
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#32316
Marie Ange Garnier (marieange)
2023-12-06 09:29
2023-06-19 11:14
35618

References
Referencing story #32316

Artifact

story #13947 Have formatting capabilities in Pull Requests
epic #28288 Revamp of Pull Request Comments
rel #32660 15.3
Display settings

Follow-ups

User avatar
Joris MASSON (jmasson)2023-12-05 11:20
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Is related to
    • Added is Covered by:
User avatar
Joris MASSON (jmasson)2023-11-30 17:36

gerrit #29914 (refactor: Stop relying on the the god PullRequest/Factory class in new ItemLabeledCollector) integrated in Tuleap 15.2.99.149

User avatar
Joris MASSON (jmasson)2023-11-21 11:19
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Manuel Vacelet (vaceletm)2023-11-16 11:35
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Manuel Vacelet (vaceletm)2023-11-16 10:29
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Joris MASSON (jmasson)2023-11-15 14:26

gerrit #29781 (refactor: Stop relying on the the god PullRequest/Factory class in new comment notification) integrated in Tuleap 15.2.99.39

User avatar
Joris MASSON (jmasson)2023-11-14 14:08

gerrit #29770 (refactor: Stop relying on the the god Factory class in PullRequestUpdatedNotificationToProcessBuilder) integrated in Tuleap 15.2.99.26

User avatar
Joris MASSON (jmasson)2023-11-02 14:33

gerrit #29625 (refactor: Create dedicated objects to retrieve pull request and pull request with its git reference) integrated in Tuleap 15.1.99.82

User avatar
Quentin Dehais (qdehais)2023-10-23 11:03
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Joris MASSON (jmasson)2023-10-20 10:01

PUT -> PATCH. We don't want to send everything, just the modified markdown content.

Also, the routes are not nested under /pull_request/{id} anymore. Doing so would require the caller to know the pull request ID, but it's not a necessary information to give. We can retrieve the comment by its ID in the database directly, and from there, we can retrieve its parent pull request, git repository and project. Seeing as we already applied this pattern for many routes (taskboard cards, gitlab groups, kanban items, etc.), it's not shocking to consider the comments and inline comments as "resources" instead of "sub-resources".

  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Thomas Gorka (tgorka)2023-09-13 11:06
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Marie Ange Garnier (marieange)2023-06-19 11:16
  • So that
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Category set to Pull Request