stable
Clone or download
part of story #32316 Update comments How to test: - Without the feature flag --> Comments without any replies have a footer containing only a [Reply] button --> Comments with replies do not have any footer --> Only the last replies of threads have a footer containing only a [Reply] button - With the feature flag (`tuleap config-set feature_flag_allow_pull_requests_comments_edition 1`) --> Comments without any replies have a footer containing an [Edit] and a [Reply button] --> Comments with replies have a footer with only an [Edit] button --> Replies which are not the last reply have a footer with only an [Edit] button --> Only the last replies of threads have a footer containing both buttons --> Comments in text format do not have a [Reply] button --> Comments whose author is not the current user do not have a [Reply] button. Change-Id: Ic278e8a6f344ad498cf6ad867c954012082933b0
Modified Files
| Name | ||||
|---|---|---|---|---|
| A | plugins/pullrequest/include/FeatureFlagEditComments.php | +40 | −0 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/PullRequestPresenter.php | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/include/pullrequestPlugin.php | +9 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestComment.ts | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentController.test.ts | +4 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentController.ts | +4 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentFooterTemplate.test.ts | +49 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentFooterTemplate.ts | +53 | −17 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/tests/stubs/PullRequestCommentControllerStub.ts | +4 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.test.ts | +5 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.vue | +3 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/constants.ts | +4 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/pullrequest-overview.ts | +5 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/app-controller.js | +4 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/types.ts | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/widgets/SideBySideCodeMirrorWidgetCreator.test.ts | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/widgets/SideBySideCodeMirrorWidgetCreator.ts | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/shared-properties/shared-properties-service.js | +11 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/FileDiffWidgetStub.ts | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/templates/pullrequest.mustache | +2 | −0 | Go to diff View file |
| A | plugins/pullrequest/tests/unit/FeatureFlagEditCommentsTest.php | +50 | −0 | Go to diff View file |