Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Retrieve comment with `CommentRetriever` object instead of `Factory`

Download Browse

Part of story #32316 Update comments Use `CommentRetriever` introduced in 6abcf65cc1370a45a65c75ce68d6871879a2f284 to retrieve a comment instead of a `Comment\Factory` which do so many things. No functionnal change expected Change-Id: Ib4bf6d9a6bfc6b41d7f1a646bb8bdf14fba1b367

+122 −110
Clarck Robinson (robinsoc) 2023-10-24 17:11
Clarck Robinson (robinsoc) 2023-10-25 15:37
a031d5522dc9f6ff60369bba17377de6cb01c0f0
93c4fa3bd50b485e2917478394973b1304c4af09
git #tuleap/stable/a031d5522dc9f6ff60369bba17377de6cb01c0f0

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Comment/Factory.php +0 −11 Go to diff View file
M plugins/pullrequest/include/PullRequest/Comment/Notification/PullRequestNewCommentNotificationToProcessBuilder.php +30 −30 Go to diff View file
M plugins/pullrequest/include/PullRequest/Notification/PullRequestNotificationSupport.php +3 −5 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/Comment/ParentIdValidatorForComment.php +17 −14 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +5 −4 Go to diff View file
M plugins/pullrequest/tests/unit/Comment/Notification/PullRequestNewCommentNotificationToProcessBuilderTest.php +20 −18 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/Comment/ParentIdValidatorForCommentTest.php +31 −28 Go to diff View file
M plugins/pullrequest/tests/unit/Stub/CommentSearcherStub.php +16 −0 Go to diff View file