Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #13013 Internal Tuleap API should not expose multiple ways to work with DB transactions
    Actions
    Infos
    #13013
    Thomas Gerbet (tgerbet)
    2019-02-28 10:59
    2019-02-20 16:58
    13880
    Details
    Internal Tuleap API should not expose multiple ways to work with DB transactions
    There is currently multiple ways to do same things.

    To start a transaction wrapping multiple things outside of a \Tuleap\DB\DataAccessObject instance you can:
    * use a \Tuleap\DB\DataAccessObject instance and call \Tuleap\DB\DataAccessObject->wrapAtomicOperations()
    * use a \Tuleap\DB\TransactionExecutor instance

    To start a transaction form within a \Tuleap\DB\DataAccessObject instance you also have multiple choices:
    * call \Tuleap\DB\DataAccessObject->wrapAtomicOperations()
    * call \Tuleap\DB\DataAccessObject->getDB()->tryFlatTransaction()


    There is no good reason to expose multiple ways to do the same things, it is not sane and can be confusing for contributors. The API must be cleaned.
    Other
    Empty
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2019-02-28
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #12561 Tuleap Releases 11.0 Delivered 2019-07-04 00:54 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #13013

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/13/14113/7' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD bd58fedff6
    User avatar Yannis ROSSETTO (rossettoy) , 2019-02-28 10:53
    request #13013: Internal Tuleap API should not expose multiple ways to work with DB transactions 5c204ceb46
    User avatar Thomas Gerbet (tgerbet) , 2019-02-27 15:17
    Referenced by request #13013

    Artifact Tracker v5

    rel #12561 11.0

    Other

    gerrit #14113
    Display settings

    Follow-ups

    User avatar
    Yannis ROSSETTO (rossettoy)2019-02-28 10:59
    Integrated into Tuleap 10.11.99.4
    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2019-02-28
    User avatar
    Thomas Gerbet (tgerbet)2019-02-21 14:38
    Patch is under review: gerrit #14113.
    • Summary
      -Internal Tuleap API should not expose multiple ways to do work with DB transactions 
      +Internal Tuleap API should not expose multiple ways to work with DB transactions 
    • Status changed from Under implementation to Under review