Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #14848 cypress tests should have eslint configuration
    Actions
    Infos
    #14848
    Marie Ange Garnier (marieange)
    2020-04-30 16:14
    2020-04-28 13:55
    16109
    Details
    cypress tests should have eslint configuration
    There are several rules we tend to use in team but who are only triggered during review.
    Let's have consistent development rules and enforce them in CI.

    - "cypress/no-assigning-return-values": "error",
    - "cypress/no-unnecessary-waiting": "error",
    - "cypress/assertion-before-screenshot": "error",
    - "cypress/no-force": "warn"
    - "cypress/require-data-selectors": "error"
    Other
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Marie Ange Garnier (marieange)
    Closed
    2020-04-30
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #14682 Tuleap Releases 11.15 Delivered 2020-01-06 10:45 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #14848

    Git commit

    tuleap/tuleap/stable

    Add eslint rule require-data-selectors for cypress f095349a03
    User avatar Marie Ange Garnier (marieange) , 2020-04-30 15:20
    Add several rules for cypress in eslint f0e646375e
    User avatar Marie Ange Garnier (marieange) , 2020-04-30 15:53
    Referenced by request #14848

    Artifact Tracker v5

    rel #14682 11.15

    Other

    gerrit #18902
    gerrit #18907
    Display settings

    Follow-ups

    User avatar
    Marie Ange Garnier (marieange)2020-04-30 10:10
    • Summary
      -cypress test should always use data-test as selector 
      +cypress tests should have eslint configuration 
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from New to Under implementation
    User avatar
    Marie Ange Garnier (marieange)2020-04-28 16:41
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    Marie Ange Garnier (marieange)2020-04-28 14:09
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes