Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #29634 MW theme seems to be harcoded to the orange theme
    Actions
    Infos
    #29634
    Thomas Gerbet (tgerbet)
    2023-01-09 13:58
    2022-11-29 14:11
    31219
    Details
    MW theme seems to be harcoded to the orange theme

    It seems the MW extensions does not take into account the stylesheet given by the REST endpoint projects/:id/3rd_party_integration_data and seems to have hardcoded one specific version.

    This is problematic because it means the user/instance preferences are not into account which can break the "same app feeling" the user should have.

    The current behavior can also future upgrade of the project sidebar component more complex as some variables might be missing.

    Mediawiki Standalone
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2023-01-09
    Attachments
    Artifact links
    Empty
    Empty
    References
    Referenced by request #29634

    Artifact Tracker v5

    request #29622 Project sidebar not shown after update
    Display settings

    Follow-ups

    User avatar
    Robert Vogel (rvogel)2022-12-01 08:39

    FYI: We require "@tuleap/project-sidebar": "^2.0.0" which didn't receive an update recently

    User avatar
    Robert Vogel (rvogel)2022-12-01 08:38

    Yes, this is most likely connected to #29622. We retrieve the user specific styles together with the "project sidebar". The variable values you found in the skin's repos are just defaults. They get overwritten with what we retrieve form the REST API.

    There are actually some variables includes that war not used in the skin. We will remove them. But we will still need to rely on variables that are passed by the REST API. The variable names must therefore be considered to be a "public interface". I don't see any way around this.

    The "project-sidebar component" itself should not be affected by future changes, as the rendering is completely done by your implementation anyways.