I didn't manage to build the package with mock (mock allows to build a rpm a fully clean environement):

$> time mock --autocache --arch=x86_64 -r centos-5-x86_64 /tmp/gitweb-tuleap-1.8.2.1-1.src.rpm
Installing /builddir/build/SRPMS/gitweb-tuleap-1.8.2.1-1.src.rpm
Building target platforms: x86_64
Building for target x86_64
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.92295
+ umask 022
+ cd /builddir/build/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /builddir/build/BUILD
+ rm -rf gitweb
+ tar -xf /builddir/build/SOURCES/gitweb-1.8.2.1.tar.gz
+ cd gitweb
++ /usr/bin/id -u
+ '[' 500 = 0 ']'
++ /usr/bin/id -u
+ '[' 500 = 0 ']'
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ cd ..
+ echo 'Patch #0 (0001-Allow-browsing-repository-regarding-user-permissions.patch):'
Patch #0 (0001-Allow-browsing-repository-regarding-user-permissions.patch):
+ patch -p1 -s
+ cd gitweb
+ cat
+ sed -e 's|@PROJECTROOT@|/var/lib/codendi/gitolite/repositories|g' /builddir/build/SOURCES/gitweb.conf.in
+ sed -i 's/^#our $projectroot/our $projectroot/g' gitweb.conf
+ sed -i -e '$a\our $projects_list = \"/var/lib/gitolite/projects.list\";' gitweb.conf
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.92295
+ umask 022
+ cd /builddir/build/BUILD
+ cd gitweb
+ LANG=C
+ export LANG
+ unset DISPLAY
+ make prefix=/usr
    SUBDIR ../
make[1]: *** No rule to make target `GIT-VERSION-FILE'.  Stop.
    GEN gitweb.cgi
    GEN static/gitweb.js
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.92295
+ umask 022
+ cd /builddir/build/BUILD
+ cd gitweb
+ LANG=C
+ export LANG
+ unset DISPLAY
+ make install gitwebdir=/usr/share/gitweb-tuleap GITWEB_PROJECTROOT=/var/lib/codendi/gitolite/repositories bindir=/usr/bin
    SUBDIR ../
make[1]: *** No rule to make target `GIT-VERSION-FILE'.  Stop.
install -d -m 755 '/usr/share/gitweb-tuleap'
install: cannot create directory `/usr/share/gitweb-tuleap': Permission denied
make: *** [install] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.92295 (%install)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.92295 (%install)

In order to reproduce, you need to generate a src.rpm out of https://tuleap.net/plugins/git/tuleap/deps/tuleap/gitweb-tuleap (rpmbuild -bs) and then run mock

\o/ I managed to got it works on a brand new CentOs 6.5 machine with rpmforge packages

What I did:

1. yum install --enablerepo=rpmforge-extras gitweb
2. deploy gitweb.pl from your branch into /usr/share/tuleap/plugins/git
3. edit /etc/gitweb.conf according to the README
4. Apply the patch for gitweb
   1. patch -p 1 /usr/share/gitweb/gitweb.cgi < /tmp/gitweb.patch
5. edit gitweb.cgi according to the README
6. chown -R gitolite:gitolite /usr/share/gitweb
7. touch /var/lib/tuleap/gitolite/repositories/gpig/blabla.git/export_repo_ok
8. Deploy the following gitweb apache conf into /etc/httpd/conf.d/tuleap-plugins/gitweb.conf
9. restart apache, it works

   Alias /gitweb /usr/share/gitweb
   
   <Directory /usr/share/gitweb>
       Options +ExecCGI
       AddHandler cgi-script .cgi
       DirectoryIndex gitweb.cgi
   </Directory>
   
   <Location /gitweb>
           AuthType Basic
           AuthName "Private Gitweb Access"
           Require valid-user
   
           AuthMYSQLEnable on
           AuthMySQLUser dbauthuser
           AuthMySQLPwEncryption md5
           AuthMySQLPassword dbpassword
           AuthMySQLDB tuleap
           AuthMySQLUserTable "user"
           AuthMySQLNameField user.user_name
           AuthMySQLPasswordField user.user_pw
           AuthMySQLUserCondition "user.status IN ('A', 'R')"
   </Location>

On Centos5 + git 1.8 still no luck, event with the modification you suggested.

What I can propose is:

• I'll review and check with my working environement on centos6 (esp. gitweb.pl in tuleap sources and gitweb.cgi modifications)
• I cannot commit for this to be working on Centos5 as I cannot reproduce a working environement on my own. It will be your responsability.

What is not really fixed yet is the packaging:

• On centos5, with git provided by epel, gitweb-tuleap should be based on that and apply the patch you developed (so git 1.8.2.1 at the time of writing). It also means that you shoud upgrade to git 1.8.2.1
• On centos6, with git provied by rpforge, gitweb-tuleap should be based on this version: gitweb-1.7.12.4-1.el6.rfx.

What do you think ?

I tested on a CentOs 6.4 x86_64. My perl version is v5.10.1.

Could you please modify this line 87 at /usr/share/tuleap/plugins/git/gitweb.pl to &db_connect;

Hi Manuel,

It works properly for me on my dev environement ( centos 5.8 i386 running perl V5.8.8) and T&I server (centos 5.9 x86_64 running perl V5.8.8).

I put the Tuleap customisation part (attached above) under /usr/share/codendi/src/utils

[root@crx19007 utils]# pwd
/usr/share/codendi/src/utils
[root@crx19007 utils]# perl -wc gitweb.pl
gitweb.pl syntax OK

Regards,

Ahmed

[root@shunt:~] # perl -wc /usr/share/tuleap/plugins/git/gitweb.pl
Scalar value @user_row[0] better written as $user_row[0] at /usr/share/tuleap/plugins/git/gitweb.pl line 21.
Scalar value @repo_row[0] better written as $repo_row[0] at /usr/share/tuleap/plugins/git/gitweb.pl line 64.
Scalar value @user_row[0] better written as $user_row[0] at /usr/share/tuleap/plugins/git/gitweb.pl line 79.
Scalar value @row[0] better written as $row[0] at /usr/share/tuleap/plugins/git/gitweb.pl line 146.
Name "main::res" used only once: possible typo at /usr/share/tuleap/plugins/git/gitweb.pl line 39.
/usr/share/tuleap/plugins/git/gitweb.pl syntax OK

Sorry I was busy with Tuleap7 I didn't had time to have a look at your proposal. I just did what you propose but I still have the same error.

My code looks like (plugins/git/gitweb.pl):

---------------------------------------------------------------------------------
use warnings;
use DBI;

#our $utils_path = $ENV{'CODENDI_UTILS_PREFIX'} || "/usr/share/tuleap/src/utils";
require "/usr/share/codendi/src/utils/include.pl";

##### Fix issues with Codex permissions #####

---------------------------------------------------------------------------------