•  
      request #8583 Invalid value in tracker XML import data crash import process
    Infos
    #8583
    Manuel Vacelet (vaceletm)
    2015-11-16 13:40
    2015-11-10 17:18
    8713
    Details
    Invalid value in tracker XML import data crash import process

    The issue is raised when attempting to display an error message about the invalid value:

    PHP Fatal error:  Call to a member function getLabel() on a non-object in /usr/share/tuleap/plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Static.class.php on line 45
    PHP Stack trace:
    PHP   1. {main}() /usr/share/tuleap/src/utils/import_project_xml.php:0
    PHP   2. ProjectXMLImporter->importFromArchive() /usr/share/tuleap/src/utils/import_project_xml.php:93
    PHP   3. ProjectXMLImporter->importContent() /usr/share/tuleap/src/common/project/ProjectXMLImporter.class.php:80
    PHP   4. EventManager->processEvent() /usr/share/tuleap/src/common/project/ProjectXMLImporter.class.php:120
    PHP   5. EventManager->processEventOnListener() /usr/share/tuleap/src/common/event/EventManager.class.php:77
    PHP   6. PluginProxy->processEvent() /usr/share/tuleap/src/common/event/EventManager.class.php:91
    PHP   7. trackerPlugin->import_xml_project() /usr/share/tuleap/src/common/plugin/PluginProxy.php:57
    PHP   8. TrackerXmlImport->import() /usr/share/tuleap/plugins/tracker/include/trackerPlugin.class.php:731
    PHP   9. TrackerXmlImport->instanciateTrackerFromXml() /usr/share/tuleap/plugins/tracker/include/TrackerXmlImport.class.php:166
    PHP  10. TrackerXmlImport->importArtifactsInNewlyCreatedTracker() /usr/share/tuleap/plugins/tracker/include/TrackerXmlImport.class.php:219
    PHP  11. Tracker_Artifact_XMLImport->importFromXML() /usr/share/tuleap/plugins/tracker/include/TrackerXmlImport.class.php:237
    PHP  12. Tracker_Artifact_XMLImport->importOneArtifactFromXML() /usr/share/tuleap/plugins/tracker/include/Tracker/Artifact/XMLImport.class.php:113
    PHP  13. Tracker_Artifact_XMLImport->importOneArtifact() /usr/share/tuleap/plugins/tracker/include/Tracker/Artifact/XMLImport.class.php:144
    PHP  14. Tracker_Artifact_XMLImport->importRemainingChangesets() /usr/share/tuleap/plugins/tracker/include/Tracker/Artifact/XMLImport.class.php:169
    PHP  15. Tracker_Artifact_Changeset_NewChangesetCreatorBase->create() /usr/share/tuleap/plugins/tracker/include/Tracker/Artifact/XMLImport.class.php:247
    PHP  16. Tracker_Artifact_Changeset_NewChangesetCreatorBase->validateNewChangeset() /usr/share/tuleap/plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreatorBase.class.php:79
    PHP  17. Workflow->checkGlobalRules() /usr/share/tuleap/plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreatorBase.class.php:234
    PHP  18. Tracker_RulesManager->validate() /usr/share/tuleap/plugins/tracker/include/workflow/Workflow.class.php:387
    PHP  19. Tracker_RulesManager->validateListRules() /usr/share/tuleap/plugins/tracker/include/Tracker/Rule/Tracker_RulesManager.class.php:150
    PHP  20. Tracker_RulesManager->getSelectedValuesForField() /usr/share/tuleap/plugins/tracker/include/Tracker/Rule/Tracker_RulesManager.class.php:741
    PHP  21. Tracker_FormElement_Field_List_Bind->formatArtifactValue() /usr/share/tuleap/plugins/tracker/include/Tracker/Rule/Tracker_RulesManager.class.php:174
    PHP  22. Tracker_FormElement_Field_List_Bind_Static->formatCriteriaValue() /usr/share/tuleap/plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind.class.php:204
    PHP  23. Tracker_FormElement_Field_List_Bind_Static->format() /usr/share/tuleap/plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Static.class.php:92

    This raise two issues:

    • First, code should not crash when attempting to display an error message
    • Second, there should not be any "Workflow validation" at XML import as it's meant to include all the crap from the past

     

    Trackers
    8.6
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Manuel Vacelet (vaceletm)
    Closed
    2015-11-16
    Attachments
    Empty
    References

    Follow-ups

    User avatar
    Merged in Tuleap 8.8.99.22

    • Status changed from Under review to Closed
    • Close date set to 2015-11-16