•  
     
    story #11105 get email notifications on pull requests - second stage
Summary
Empty
get email notifications on pull requests - second stage

I know when I got something to review

Add / remove reviewers

After having created a PR, on the PR view, there is a list of reviewers that is empty.

I can click on "Edit" to add people:

Both with auto-completers (I cannot add raw email address)

When people/groups are added they get a notification about the PR to reviews.

It's possible to remove reviewers with the same process.

"Owner" of the PR is automatically part of the notification list. Who is "owner":

  • creator of PR
  • commit author => NO, we don't want to notify linux kernel contributors
  • push author

Notifications

What triggers a notifications

  • A new comment (there will be one email per comment) (done in story #14190)
  • A new push in the branch (done in story #14190)
  • A Jenkins update of the branch
  • Being added as a reviewer (only new reviewers are notified, existing reviewers are not notified about add/remove) (done in story #14190)

There is a check of permissions as well as an email de-duplication at sending time to avoid leaking informations.

The code should also respect "Truncated Emails"

Notifications are handled with Backend Workers (Redis) whenever possible to avoid slowdown on push/comment & co.

Content of the notification to be defined

  1. On reviewer added:
    1. commit summary (id, shortlog)
    2. stats (list of files + status)
    3. link to the PR (done in story #14190)
  2. On comment: (done in story #14190)
    1. link to the PR
    2. comments + context (file, code fragment)
  3. On push:
    1. link to the PR (done in story #14190)
    2. shortlog of modified files (/!\ force push)
  4. Merge/abandon (done in story #14190)
    1. link to the PR
    2. status of PR
  5. Jenkins
    1. link to the PR
    2. CI status (only for the last commit of the PR, only if the CI status change)
  6. On title/description change? => NO

Bonus: The information of reviewers added/removed is displayed in the PR log

Nouha Terzi (terzino), Denis PILAT (denis_pilat)
Status
To be done
Development
  • Does it involves User Interface? 
  • Are there any mockups?
  • Are permissions checked?
  • Does it need Javascript development?
  • Does it need a forge upgrade bucket?
  • Does it need to execute things in system events?
  • Does it impact project creation (templates)?
  • Is it exploratory?
Empty
Details
#11105
Manuel Vacelet (vaceletm)
2019-12-20 13:05
2018-02-05 16:42
14468

References

List of items referenced by or referencing this item.

Artifact Tracker v5

Follow-ups

  • User avatar
    • Acceptance criteria
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
  • User avatar
    This story has been split. The first part is story #14190 and is scoped for Tuleap 11.9 (rel #13877). I will update this story once Tuleap 11.9 is released with the remaining work.

    • I want to
      -get email notifications on pull requests 
      +get email notifications on pull requests - second stage 
  • User avatar
  • User avatar
    • Acceptance criteria
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
  • User avatar
    • Acceptance criteria
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
  • User avatar
    • Acceptance criteria
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
  • User avatar
  • User avatar
    • CC list set to Denis PILAT (denis_pilat), Nouha Terzi (terzino)
  • User avatar
    • So that
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Acceptance criteria
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Attachments 1-pull-request-with-notifications.png, 2-update-pull-request.png added
    • Permissions set to