Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #11664 display list of commits of a pull request
Actions
Summary
Empty
display list of commits of a pull request
Empty

In pull request view, there is a new tab "Commits" that list all the commits of the pr, grouped by day with:

  • commit summary
  • author
  • date
  • build status when available
  • link to commit diff in git view

See attached mock-up.

Limits

  • Contrary to github, the sha1 will point to repository diff instead of presenting the diff in the context of the PR. The main difference, in addition to the context switch is that it will not be possible to comment. If needed, the feature can be implemented later.
  • In order to re-use design, this need to be implemented after the implementation of Modern Git epic with burning parrot look & feel (see epics #10400)

References for git route

By Manuel Vacelet (vaceletm)
(276 kB)
git-pr-commit-list.png
Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#11664
Manuel Vacelet (vaceletm)
2018-10-04 09:55
2018-06-22 10:31
4306

References
Artifact links
Empty
Referencing story #11664

Artifact Tracker v5

epic #11662 Pull requests
rel #12154 10.6

Git commit

tuleap/tuleap/stable

Introduce new route /pull_requests/{id}/commits 725fd9b235
User avatar Marie Ange Garnier (marieange) , 2018-09-05 14:18
Add generic informations to pullrequest commit representation a2bc82eb89
User avatar Marie Ange Garnier (marieange) , 2018-09-07 12:05
Add Tuleap users information to representation f9a2f65618
User avatar Marie Ange Garnier (marieange) , 2018-09-10 10:47
List commits of a pull request f0709e85cc
User avatar Nicolas Terray (nterray) , 2018-09-18 09:23
Display last commit status in PR commits d8a697ffbe
User avatar Nicolas Terray (nterray) , 2018-09-19 15:47
Introduce tlp-card component 3b532188b8
User avatar Nicolas Terray (nterray) , 2018-09-21 09:31
Retrieving a set of commits via the REST API is fast again 1a7eb79d32
User avatar Thomas Gerbet (tgerbet) , 2018-09-27 16:32
Set of commit statuses is retrieved with the expected values fbe1686823
User avatar Thomas Gerbet (tgerbet) , 2018-09-28 11:42
Display settings

Follow-ups

User avatar
Nicolas Terray (nterray)2018-09-21 11:05
After experimentation and discussion with UXD, it has been decided to not group commit by day for now. It will be done later, if needed.
User avatar
Manuel Vacelet (vaceletm)2018-06-22 10:31
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes