Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #13292 Integrate vimeo/psalm to the test pipeline
    Infos
    #13292
    Thomas Gerbet (tgerbet)
    2019-07-19 11:00
    2019-04-23 15:14
    14164
    Details
    Integrate vimeo/psalm to the test pipeline
    This is the next stage of request #13038.

    Goal here is to be able to integrate and enforce Psalm checks in our test pipeline.
    Due to the resources needed to achieve the static analysis, we might be forced to only check modified files of each patchset which means we might miss changes affecting the unmodified parts of the codebase.


    This request will mostly be about the stabilization of what we already have, most issues/false positives are due to the way(s) Tuleap loads its classes and files, depending on the entry point you might encounter functions/classes that are not loaded but exist in the codebase. This does not help tools analyzing code at all.

    This request will also take care of solving issues spotted by Psalm introduced since we run Psalm in the nightly pipeline.

    We will also need to wait for the next release of Psalm (current release 3.2.9) to not have to work around some issues (e.g. [0])


    [0] https://github.com/vimeo/psalm/issues/1542
    Dev tools
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2019-07-19
    Attachments
    By Thomas Gerbet (tgerbet)
    (21 kB)
    psalm-report-uniq.txt
    By Thomas Gerbet (tgerbet)
    (3 kB)
    psalm-report-uniq-15072019.txt
    References
    Referencing request #13292

    Artifact

    request #13374 REST API GET /artifacts/{id}/linked_artifacts does not return the representation of the linked artifacts
    request #13604 Link to the notification mail when a user is added to a project is incomplete
    request #13663 "gotoid" links in legacy trackers are broken
    Display settings

    Follow-ups

    User avatar
    Yannis ROSSETTO (rossettoy)2019-07-19 11:00
    gerrit #15459 (Remove \group_add_history() function) Integrated into Tuleap 11.3.99.172
    • Status changed from Under implementation to Closed
    • Connected artifacts
    • Close date set to 2019-07-19
    User avatar
    Thomas Gerbet (tgerbet)2019-06-24 09:51
    So to found the issues only visible when analyzing a part of the codebase, I have analyzed each file individually and consolidated all the reports. Result attached.
    User avatar
    Thomas Gerbet (tgerbet)2019-06-07 14:01
    The current state is not too bad, the integration in the CI tets pipeline works quite well. Before closing this I want to fix all the issue that are found only when a file is analyzed without the whole codebase. Those issues can be confusing for a contributor because they can be triggered on code section not touched or impacted by the contribution.