Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #13377 Retrieval of the first transition of the current state can crash if there is no changeset or the changeset value for the field does not exist
    Actions
    Infos
    #13377
    Thomas Gerbet (tgerbet)
    2019-05-14 15:08
    2019-05-14 10:20
    14498
    Details
    Retrieval of the first transition of the current state can crash if there is no changeset or the changeset value for the field does not exist
    In some cases we might have no changeset value for a field (see for example this other issue: request #13376). If a workflow is enabled on this field, the retrieval of the workflow information might lead to a PHP fatal error.

    Even this situation is not supposed to happen, the code should take into account all possible values exposed by the internal API.



    Trace:
    PHP Fatal error: Uncaught Error: Call to a member function getValue() on null in /usr/share/tuleap/plugins/tracker/include/Workflow/Workflow.class.php:393"
    Stack trace:
    #0 /usr/share/tuleap/plugins/tracker/include/Workflow/PostAction/ReadOnly/ReadOnlyFieldDetector.php(46): Workflow->getFirstTransitionForCurrentState(Object(Tracker_Artifact))
    #1 /usr/share/tuleap/plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field.class.php(582): Tuleap\Tracker\Workflow\PostAction\ReadOnly\ReadOnlyFieldDetector->isFieldReadOnly(Object(Tracker_Artifact), Object(Tracker_FormElement_Field_Selectbox))"
    #2 /usr/share/tuleap/plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field.class.php(378): Tracker_FormElement_Field->fetchArtifactValueForWebDisplay(Object(Tracker_Artifact), Object(Tracker_Artifact_ChangesetValue_List), Array)
    #3 /usr/share/tuleap/plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Container.class.php(293): Tracker_FormElement_Field->fetchArtifa...
    Trackers
    11.0
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2019-05-14
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #13072 Tuleap Releases 11.2 Delivered 2019-05-29 16:32 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #13377

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/61/14961/1' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD abe65464bc
    User avatar Yannis ROSSETTO (rossettoy) , 2019-05-14 15:06
    request #13377: Retrieval of the first transition of the current state can crash 93e2085e42
    User avatar Thomas Gerbet (tgerbet) , 2019-05-14 11:24
    Display settings

    Follow-ups

    User avatar
    Yannis ROSSETTO (rossettoy)2019-05-14 15:08
    Integrated into Tuleap 11.1.99.61
    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2019-05-14
    User avatar
    Thomas Gerbet (tgerbet)2019-05-14 11:29
    Fix can be reviewed here: gerrit #14961.
    • Summary
      -Retrieval of the first transition of the current state can crash if there is no changeset or the changeset for the field does not exist 
      +Retrieval of the first transition of the current state can crash if there is no changeset or the changeset value for the field does not exist 
    • Status changed from Under implementation to Under review