Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #13567 decide that custom services opens in a new tab/window by default
Actions
Summary
project administrator
decide that custom services opens in a new tab/window by default

I don't loose the context of Tuleap project when I'm using custom services to integrate with external tools

Functional overview

When project admin configures the service, she can choose "Open in a new tab" option (off by default). If "Display in iframe" option was checked before, a warning is shown when "Open in a new tab" is checked.

"Display in iframe" is now deprecated so the this field isn't displayed in the new service modal.

As a user, when I click on the link configured link, it opens in a new tab.

Technical overview

Security constraint: links must be built with rel="noopener noreferrer" to block reverse tabnabbing.

Design

Empty
Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#13567
Manuel Vacelet (vaceletm)
2019-08-21 17:44
2019-07-01 10:08
4026

References
Artifact links
Empty
Referencing story #13567

Artifact Tracker v5

rel #13416 11.5
epic #13565 Project Admin

Git commit

tuleap/tuleap/stable

Display services opened in new tabs ac6d3fe2fa
User avatar Manuel Vacelet (vaceletm) , 2019-08-08 14:18
Reformat and type Service class db250b9729
User avatar Manuel Vacelet (vaceletm) , 2019-08-09 11:20
Each servic should provide icon name 20d509855c
User avatar Nicolas Terray (nterray) , 2019-08-16 11:23
Choose and save Open in a new tab in edit service modal 3ae488d875
User avatar Joris MASSON (jmasson) , 2019-08-16 14:31
Fix alignment of open in new tab extra icon 08f15f9ab1
User avatar Nicolas Terray (nterray) , 2019-08-16 17:57
Do not raise 404 on service creation ef16421c4b
User avatar Nicolas Terray (nterray) , 2019-08-19 11:55
I can update Admin service 30d487712e
User avatar Nicolas Terray (nterray) , 2019-08-19 10:49
Select icon and open in new tab in Add modal 3f686d9af8
User avatar Joris MASSON (jmasson) , 2019-08-19 17:26
Do not promote http protocol 0384148d71
User avatar Nicolas Terray (nterray) , 2019-08-19 17:44
Do not glue in-new-tab icon 7b6e02b463
User avatar Nicolas Terray (nterray) , 2019-08-19 16:14
Save Icon and open in new tab when adding a service 5e251d4aaa
User avatar Joris MASSON (jmasson) , 2019-08-20 09:37
Remove help block for link 9027c0da42
User avatar Nicolas Terray (nterray) , 2019-08-20 09:32
Preview should show the "New tab" icon f19cffe9fd
User avatar Joris MASSON (jmasson) , 2019-08-20 10:18
Inherit icon and "new tab" in new project b26b6b1a57
User avatar Joris MASSON (jmasson) , 2019-08-20 11:22
Avoid display of internal key to end user 7e6761647c
User avatar Nicolas Terray (nterray) , 2019-08-20 13:28
Fix calls on possibly null reference when a \Service is expected f5c2cf7e99
User avatar Thomas Gerbet (tgerbet) , 2019-08-21 10:06
TTM service should provide icon name 55b0fe5359
User avatar Nicolas Terray (nterray) , 2019-08-16 11:26
baseline service should provide icon name 7396de968d
User avatar Nicolas Terray (nterray) , 2019-08-16 11:31
Display settings

Follow-ups

User avatar
Benjamin Dauton (bdauton_enalean)2019-07-05 11:20
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Benjamin Dauton (bdauton_enalean)2019-07-05 09:59
  • So that
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes