Tuleap 16 est là ! Assistez à l'événement virtuel le 17 octobre à 10h30. Inscrivez-vous ici !

  •  
     
    story #13567 decide that custom services opens in a new tab/window by default
Summary
project administrator
decide that custom services opens in a new tab/window by default

I don't loose the context of Tuleap project when I'm using custom services to integrate with external tools

Functional overview

When project admin configures the service, she can choose "Open in a new tab" option (off by default). If "Display in iframe" option was checked before, a warning is shown when "Open in a new tab" is checked.

"Display in iframe" is now deprecated so the this field isn't displayed in the new service modal.

As a user, when I click on the link configured link, it opens in a new tab.

Technical overview

Security constraint: links must be built with rel="noopener noreferrer" to block reverse tabnabbing.

Design

Empty
Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#13567
Manuel Vacelet (vaceletm)
2019-08-21 17:44
2019-07-01 10:08
4026

References
Referencing story #13567

Git commit

tuleap/tuleap/stable

Display services opened in new tabs ac6d3fe2fa
Reformat and type Service class db250b9729
Each servic should provide icon name 20d509855c
Choose and save Open in a new tab in edit service modal 3ae488d875
Fix alignment of open in new tab extra icon 08f15f9ab1
Do not raise 404 on service creation ef16421c4b
I can update Admin service 30d487712e
Select icon and open in new tab in Add modal 3f686d9af8
Do not promote http protocol 0384148d71
Do not glue in-new-tab icon 7b6e02b463
Save Icon and open in new tab when adding a service 5e251d4aaa
Remove help block for link 9027c0da42
Preview should show the "New tab" icon f19cffe9fd
Inherit icon and "new tab" in new project b26b6b1a57
Avoid display of internal key to end user 7e6761647c
Fix calls on possibly null reference when a \Service is expected f5c2cf7e99
TTM service should provide icon name 55b0fe5359
baseline service should provide icon name 7396de968d

Follow-ups

User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
  • So that
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes