Description	Shortcut
Open this window	`?`
Open the "+ New" dropdown	`c`
Go to personal dashboard	`d`
Open the "Switch to..." modal	`/` / `s`

Description	Shortcut
Focus first sidebar service	`shift + g`
Go to Test Management	`g + e`
Go to Trackers	`g + t`
Go to Git	`g + i`
Go to Documents	`g + d`
Go to Backlog	`g + b`
Go to Kanban	`g + k`

request #13943 Remove all file level phpcs ignore annotations

Infos

Artifact ID#13943

Submitted byThomas Gerbet (tgerbet)

Last Modified On2019-10-01 08:31

Submitted on2019-09-27 16:13

Rank15158

Details

Summary *

Remove all file level phpcs ignore annotations

Original Submission

In some PHP files, PHPCS has been completely disabled using "@codingStandardsIgnoreFile" or "phpcs:ignoreFile".

It's annoying because it prevents the auto-fixing of those files when we add new rules. We should remove the global annotations, auto-fix the files and add more precise annotations to deal with the less easy to fix existing issues.

CategoryDev tools

Reported in versionEmpty

PlatformEmpty

Is an Enhancement or an internal improvement?

[ ] enhancement
[ ] internal improvement

CC listEmpty

Stage

Assigned toThomas Gerbet (tgerbet)

StatusClosed

Close date2019-10-01

Attachments

Connected artifacts

Artifact links

By type:
Fixed in
Trackers:
Releases

	Artifact ID	Project	Tracker	Summary	Status	Last Update Date	Submitted By	Assigned to
	rel #13800	Tuleap	Releases	11.7	Delivered	2019-10-17 15:09	Manuel Vacelet (vaceletm)

Reverse artifact links

By type:
Trackers:

Empty

AttachmentsEmpty

References

Cross references

Referencing request #13943

Git commit

tuleap/tuleap/stable

Merge commit 'refs/changes/80/16280/3' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD ddff900d33

Nicolas Terray (nterray) , 6 years ago

request #13943: Remove all file level phpcs ignore annotations ed3e9bce55

Thomas Gerbet (tgerbet) , 6 years ago

Show items referenced by request #13943

Referenced by request #13943

Artifact Tracker v5

rel #13800 11.7

Other

Follow-ups

Nicolas Terray (nterray)

6 years ago

gerrit #16280 integrated into Tuleap 11.6.99.55

Status changed from Under review to Closed
Connected artifacts
- Added Fixed in: rel #13800
Close date set to 2019-10-01

Thomas Gerbet (tgerbet)

6 years ago

Patch can be reviewed here: gerrit #16280.

Status changed from Under implementation to Under review

of

by