•  
      story #14008 customize FRS Download Agreement in my project
    Summary
    Empty
    customize FRS Download Agreement in my project

    I can have a legal text that's better suited to my context

    Overview

    Configuration as FRS administrator

    As an FRS administrator, in my project's FRS administration I have a new tab next to 'Processors'.

    This new tab is labeled "License Agreements". It presents a list of license agreements that can be selected for my packages.

    By default there are 2 entries:

    • No license (if $sys_frs_license_mandatory is set to 0 in configuration)
    • Platform default (corresponds to what we have ATM as download agreement)

    It's possible to create new entries with 2 informations:

    • A label
    • A full text description with a HTML editor like ckeditor for embedded documents in docman

    It's possible to select one of License Agreement (including No License) as the new default that will apply for all futur packages.

    It's possible to delete an existing custom License Agreement if it's no longer used in an Active Package.

    • When someone remove a License Agreement that was used in a "Hidden" package, the package is updated with the new default defined in the project.

    Selection as FRS administrator

    As an FRS administrator, when I create a new package, in the creation form of the package, instead of the "Yes/No" select box in the current interface:

    1849-image-20191014152537-2.png

    The "License Approval" select box lists all possible "License Approval" (including "No" when allowed by the platform). The default defined by the FRS admin is used "by default".

    Approval by a Downloader

    On a download of a file in a package, the selected "License Approval" is displayed for approval to end user.

    Note: the exact behaviour will be completed later on as the current state of the code cannot be modied (too old, too legacy) and the feature must be re-designed from scratch.

    In addition to the legacy FRS interface, we will need to update the one provided by "FRS Plugin" too in order to be consistent:

    1851-image-20191024091239-1.png

    That probably means that we will have to export the license agreement information via REST routes in some ways.

    Another "feature" that was discovered thanks to a mysterious comment in the code, apparently, the license agreement popup also takes into account the `file` key word:

    1853-Peek%202019-10-25%2010-36.gif

    Denis PILAT (denis_pilat)
    Status
    Done
    Development
    Empty
    Empty
    Details
    #14008
    Manuel Vacelet (vaceletm)
    2019-11-12 16:08
    2019-10-14 15:32
    14309

    References

    Follow-ups

    • User avatar
      gerrit #16696 integrated into Tuleap 11.7.99.144.

      • Status changed from On going to Done
    • User avatar
      gerrit #16694 integrated into Tuleap 11.7.99.142.
    • User avatar
      gerrit #16691 integrated into Tuleap 11.7.99.141.
    • User avatar
      gerrit #16687 integrated into Tuleap 11.7.99.130.
    • User avatar
      gerrit #16683 integrated into Tuleap 11.7.99.128.
    • User avatar
      gerrit #16659 integrated into Tuleap 11.7.99.123.
    • User avatar
      gerrit #16644 integrated into Tuleap 11.7.99.121.
    • User avatar
      gerrit #16643 integrated into Tuleap 11.7.99.111.
    • User avatar
      gerrit #16634 integrated into Tuleap 11.7.99.107.
    • User avatar
      gerrit #16623 integrated into Tuleap 11.7.99.102.
    • User avatar
      gerrit #16614 integrated into Tuleap 11.7.99.92.
    • User avatar
      gerrit #16613 integrated into Tuleap 11.7.99.90.
    • User avatar
      • Status changed from To be done to On going
    • User avatar
      gerrit #16609 integrated into Tuleap 11.7.99.81
    • User avatar
      gerrit #16605 integrated Tuleap 11.7.99.79
    • User avatar
      gerrit #16600 integrated into Tuleap 11.7.99.76 .
    • User avatar
      gerrit #16563 integrated into Tuleap 11.7.99.67 .
    • User avatar
      gerrit #16562 integrated into Tuleap 11.7.99.56 .
    • User avatar
      gerrit #16554 integrated into Tuleap 11.7.99.54 .

      • Acceptance criteria
    • User avatar
      • Acceptance criteria
      • Attachments image-20191025105206-1.png removed; Peek 2019-10-25 10-36.gif added
    • User avatar

      What' always a pleasure when we have to rework such an old code (some lines are from 2002!) is that we are always delighted by the feature we unveil !


      • Acceptance criteria
      • Attachments image-20191025105206-1.png added
    • User avatar

      @denis_pilat while starting the implementation we uncover a part that was not taken into account during the initial estimations. I update the acceptance criteria accordingly.

       


      • So that
      • Acceptance criteria
      • Attachments image-20191024091239-1.png added