•  
     
    story #14008 customize FRS Download Agreement in my project
Summary
Empty
customize FRS Download Agreement in my project

I can have a legal text that's better suited to my context

Overview

Configuration as FRS administrator

As an FRS administrator, in my project's FRS administration I have a new tab next to 'Processors'.

This new tab is labeled "License Agreements". It presents a list of license agreements that can be selected for my packages.

By default there are 2 entries:

  • No license (if $sys_frs_license_mandatory is set to 0 in configuration)
  • Platform default (corresponds to what we have ATM as download agreement)

It's possible to create new entries with 2 informations:

  • A label
  • A full text description with a HTML editor like ckeditor for embedded documents in docman

It's possible to select one of License Agreement (including No License) as the new default that will apply for all futur packages.

It's possible to delete an existing custom License Agreement if it's no longer used in an Active Package.

  • When someone remove a License Agreement that was used in a "Hidden" package, the package is updated with the new default defined in the project.

Selection as FRS administrator

As an FRS administrator, when I create a new package, in the creation form of the package, instead of the "Yes/No" select box in the current interface:

1849-image-20191014152537-2.png

The "License Approval" select box lists all possible "License Approval" (including "No" when allowed by the platform). The default defined by the FRS admin is used "by default".

Approval by a Downloader

On a download of a file in a package, the selected "License Approval" is displayed for approval to end user.

Note: the exact behaviour will be completed later on as the current state of the code cannot be modied (too old, too legacy) and the feature must be re-designed from scratch.

In addition to the legacy FRS interface, we will need to update the one provided by "FRS Plugin" too in order to be consistent:

1851-image-20191024091239-1.png

That probably means that we will have to export the license agreement information via REST routes in some ways.

Another "feature" that was discovered thanks to a mysterious comment in the code, apparently, the license agreement popup also takes into account the `file` key word:

1853-Peek%202019-10-25%2010-36.gif

Denis PILAT (denis_pilat)
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#14008
Manuel Vacelet (vaceletm)
2019-11-12 16:08
2019-10-14 15:32
14930

References
Referencing story #14008

Git commit

tuleap/tuleap/stable

src/common/FRS to match PSR4 f64521356b
Extract existing License Agreement code 7d4fcad50f
Replace showConfirmDownload by a bootstrap modal 1f3519ad56
Remove entirely the old "confirm_download" stuff 0bab17558e
Display different download agreement on packages 25af346da3
Display custom license agreements in FRS plugin 563d0c2797
Use LicenseAgreementFactory 74ca7b1a20
Extract code that deal with license approval at package creation/update e996117967
Edit package with custom agreement 2bb6b79317
Introduce new administration page 21054d8241
List all available license agreements ec0758997c
Display, edit and save a license agreement de3c4d02b8
Create new license agreement 10a014b1af
Display and use default license b2983596eb
Save project default license 201f0c959b
Delete license agreement 62f899dbee
Duplicate license agreements as project creation 322655d33b
Refactoring: use LicenseAgreementControllersHelper evenly f88e0ec2d8

Follow-ups

User avatar
gerrit #16554 integrated into Tuleap 11.7.99.54 .

  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar

What' always a pleasure when we have to rework such an old code (some lines are from 2002!) is that we are always delighted by the feature we unveil !


  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Attachments image-20191025105206-1.png added
User avatar

@denis_pilat while starting the implementation we uncover a part that was not taken into account during the initial estimations. I update the acceptance criteria accordingly.

 


  • So that
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Attachments image-20191024091239-1.png added