•  
      request #14204 Make sure all rejected promises are handled in the test suites
    Infos
    #14204
    Thomas Gerbet (tgerbet)
    2019-11-21 17:33
    2019-11-21 14:13
    15465
    Details
    Make sure all rejected promises are handled in the test suites
    Following request #14155 those errors can be seen when running the Jest test suites:

    (node:107400) UnhandledPromiseRejectionWarning: [object Object]
    (node:107400) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
    (node:107400) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    (node:107400) UnhandledPromiseRejectionWarning: [object Object]
    (node:107400) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)


    This is due to a behavior change in one of the updated library but the changes should have been found by our test suites and not silently ignored.
    Dev tools
    development
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2019-11-21
    Attachments
    Empty
    References

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2019-11-21 14:23
    Patch can be reviewed: gerrit #16830.

    • Summary
      -Make sure all promises are handled in the test suites 
      +Make sure all rejected promises are handled in the test suites 
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from Under implementation to Under review