Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #14897 see rendered html diff in artifact changes
Actions
Summary
Empty
see rendered html diff in artifact changes

I'm not polluated by markup changes

Context

Display of diff with rendered html (instead of markup diff) is possible but costly because we need to iteratively use HTMLPurifier on the diff and each invocation is noticable. Even with only 10 changes in an artifact the artifact display is slowed down.

Rendering of text fields diff should be reworked to be on demand / asych.

Proposal

When "Show diff" is clicked, the diff is fetched from the server with the new "rendered diff" mode by default.

In addition to this "rendered diff" view, there is an option to see the markup difference (see mockup)

Not changed

  • Modals don't change (no change rendered in modals)
  • Mails don't change (it's already a link to the artifact view)
By Benjamin Dauton (bdauton_enalean)
(257 kB)
1.png
By Benjamin Dauton (bdauton_enalean)
(242 kB)
2.png
Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#14897
Manuel Vacelet (vaceletm)
2020-08-13 11:44
2020-05-20 13:58
3931

References
Artifact links
Referencing story #14897

Artifact Tracker v5

epic #2047 Tracker
rel #14818 11.18

Git commit

tuleap/tuleap/stable

Show diff button must be displayed only when there is a diff to display 5ec3987fa9
User avatar Marie Ange Garnier (marieange) , 2020-08-04 09:26
FollowUpPresenter breaks immutability constraints 06e635e837
User avatar Thomas Gerbet (tgerbet) , 2020-08-04 08:27
Add the switch to markup format button 66215cbf07
User avatar Marie Ange Garnier (marieange) , 2020-08-05 15:11
Add the switch to markup format button 418807b5e7
User avatar Marie Ange Garnier (marieange) , 2020-08-05 14:57
Add a new level of purifier 58f08d2572
User avatar Marie Ange Garnier (marieange) , 2020-08-04 12:14
Toggle changeset cbd7e0090d
User avatar Marie Ange Garnier (marieange) , 2020-08-03 12:07
Add a carret icon in "diff" button for text changeset 1d5825cd34
User avatar Marie Ange Garnier (marieange) , 2020-07-29 11:53
Display settings

Follow-ups

User avatar
Manuel Vacelet (vaceletm)2020-05-26 14:05
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Benjamin Dauton (bdauton_enalean)2020-05-25 17:03
  • So that
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Attachments 1.png, 2.png added