•  
      request #15132 Crash when accessing the panel of a non-existent/deleted planning
    Infos
    #15132
    Thomas Gerbet (tgerbet)
    2020-07-20 15:15
    2020-07-20 10:54
    16398
    Details
    Crash when accessing the panel of a non-existent/deleted planning
    Issue can be reproduced easily by opening the Overview panel of a milestone and modifying the planning_id GET parameter to something that does not exist.


    Trace:
    Fatal error: Uncaught TypeError: Argument 3 passed to Planning_MilestoneFactory::getBareMilestoneByArtifactAndPlanning() must be an instance of Planning, null given, called in /usr/share/tuleap/plugins/agiledashboard/include/Planning/MilestoneFactory.class.php on line 237 and defined in /usr/share/tuleap/plugins/agiledashboard/include/Planning/MilestoneFactory.class.php on line 204
    TypeError: Argument 3 passed to Planning_MilestoneFactory::getBareMilestoneByArtifactAndPlanning() must be an instance of Planning, null given, called in /usr/share/tuleap/plugins/agiledashboard/include/Planning/MilestoneFactory.class.php on line 237 in /usr/share/tuleap/plugins/agiledashboard/include/Planning/MilestoneFactory.class.php on line 204
    Call Stack
    # Time Memory Function Location
    1 0.0001 404648 {main}( ) .../index.php:0
    2 0.0079 2572040 Tuleap\Request\FrontRouter->route( ) .../index.php:49
    3 0.0123 3336200 Tuleap\Request\FrontRouter->routeHandler( ) .../FrontRouter.php:109
    4 0.0219 3973056 Tuleap\AgileDashboard\AgileDashboardLegacyController->process( ) .../FrontRouter.php:247
    5 0.0243 4102480 AgileDashboardRouter->route( ) .../AgileDashboardLegacyController.php:80
    6 0.0253 4224872 AgileDashboardRouter->routeShowPlanning( ) .../AgileDashboardRouter.class.php:269
    7 0.0255 4232720 AgileDashboardRouter->renderAction( ) .../AgileDashboardRouter.class.php:592
    8 0.0255 4232720 AgileDashboardRouter->executeAction( ) .../AgileDashboardRouter.class.php:546
    9 0.0255 4232720 Planning_MilestoneController->show( ) .../AgileDashboardRouter.class.php:567
    10 0.0255 4232720 Planning_MilestoneController->generateBareMilestone( ) .../MilestoneController.class.php:76
    11 0.0255 4232720 Planning_MilestoneFactory->getBareMilestone( ) .../MilestoneController.class.php:176
    12 0.0268 4412784 Planning_MilestoneFactory->getBareMilestoneByArtifactAndPlanning( ) .../MilestoneFactory.class.php:237
    Agile Dashboard
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2020-07-20
    Attachments
    Empty
    References

    Follow-ups