•  
     
    story #17180 take into account gitlab commits
Summary
Empty
take into account gitlab commits
Empty

Follow up of story #17178

  • When a git commit is pushed to gitlab, Gitlab triggers the Tuleap webhook. Tuleap parses the pushed commits to create cross references.
  • The cross reference is created when the pattern "TULEAP-XXXX" (case insensitive) is used in git commit message and that XXXX is a valid artifact.
  • On Tuleap side, it creates a gitlab_commit #myrepo/sha1 reference that can be used consistently across tuleap.
  • In artifact view (only, not in modals) the display of gitlab commit cross references is made with a table (instead of a comma separated list of refs)
  • The same kind of display is applied to Tuleap git commits (consistency)
  • The last push date is recorded so it can be used to display the "gitlab git repo" with an accurate date (order by last push)

Expected new display of cross ref

https://www.figma.com/proto/FJQMRxPdtgPrF2SJlbZm72/References-in-Artifact-view?node-id=1%3A3&viewport=480%2C338%2C0.5&scaling=scale-down

The new look & feel (tiles based) is applied for all cross references:

  • gitlab_commit, git, tracker natures are displayed with extended informations
  • other references are displayed with the "current" level of information aka mostly the id.
Empty
Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#17180
Manuel Vacelet (vaceletm)
2021-01-07 10:40
2020-10-07 10:41
3811

References
Referencing story #17180

Git commit

tuleap/tuleap/stable

Event get_reference is now an object 25b4d918cf
Packaging GitLab plugin for TEE 6d4eb44b8b
Add missing unit tests f9a0271585
Parse post push commit webhook content e44d5477b2
Add missing exception message for RepositoryNotFoundException 8e7efe0420
Show/hide xrefs bfe9e4a0b4
Use mustache to display cross references 91ad759044
Parse TULEAP-{:id} references in commit messages cc636720ea
Two GitLab repositories with the same name cannot be integrated in the same project 37e45e9128
Can't create integration of 2 repositories with same name a7dc926580
Display xRefs in Tracker with its own mustache dd7ec7a20e
Use mutache to display empty state in xRefs f2035aa139
gitlab_commit references are now usable 5012af1d66
Add icon of xrefs 2fe3c8bba4
Display "referencing" and "referenced by" in 2 sections 0e99c6b00f
Bug when a both xRefs is deleted 7e553fa2d8
Add cross-reference gitlab_commit while parsing post push webhook 343ab8063c
Don't throw error when xRefs doesn't exist 7d7c025f30
Console warning in git plugin 0af5382280
Use tlp-pane in mustache f7cd2e8995
Display cross references as cards a433c75214
Refactoring: Available natures icons e1e800e7b1
Group commit references by section 78356eef75
Do not display git xref for unreadable repository 2ebfe3f5fc
Insert gitlab commit data in DB 9f055c5fc6
Refactoring: Primitive obsession with available natures f2a6110f87
Pimp my artifact cross reference 254c9c8af6
Don't display xRefs with deleted tracker 4014b79339
Display sha1 commit as badge in cross reference 6249ae79c1
Sort nature & sections alphabetically 0d6ff19c14
Warn project admin when a gitlab_commit reference previously exists 600f9c2a56
Organize GitLab references fe197ee212
get_available_reference_natures should be a dispatchable event 1094dacf54
Refacto: rename cross_reference to cross_reference_presenter in nature organizer 01f93fb70b
Move two unit test files at the right place e3a061a6c1
Display commit information instead of raw cross ref label 4ca2f10e2b
Fix GitlabCrossReferenceOrganizerTest 5e95839fb5
Make possible to identify GitLab webhook requests in the metrics 939a5c59b5
Store plugin_gitlab_commit nature name in a constant 8275b382cb
Fix psalm issue with \ReferenceManager::getReferencesByGroupId() e2626ea48d
Get commit GitLab branch cdbc5b96cf
Refacto: \Tuleap\Test\Builders\CrossReferencePresenterBuilder 6612738a02
Display titles and avatars in gitlab xRefs 6cf2039513
Display icon color next to document references ddddeea383
Use hash map instead of flat array in nature organizer d0ccafaf18
Display current branch/tag if git reference 3e2d0ebd8c
Refactoring: centralize project access check for xrefs 62059f9e2e
Display branch name of GitLab commits d62e740516
Do not display cross references of unreadable wiki pages 8c6c2fac1a
Refacto: rename a part of `common/reference` to `common/Reference` to be PSR-4 compatible e221395b6a
Continue to rename `common/reference` to `common/Reference` and transform *.class.php to *.php in common/Reference f1c79b49a2
Do not display inaccessible cvs commit in cross ref eb2a46cda1
Do not display xRef for unreadable frs release cf6bac6f61
Display missing icons in front of natures ff2b0699bd
Do not display xRef for unreadable FRS files 84f1fe7bd0
Do not display xref to unreachable forum message 2f49ca31dd
Do not display xref to unreachable forum 3698fffd15
Do not display xRef for unreadable hudson builds/jobs 971914e789
Display xref sparklines next to the title 8d329ca3ca
Cache git commit details in db 5baac14c7e
Do not display xRef for unreadable news ca70e50b5d
tuleap-plugin-gitlab is part of TCE cb7706c1d1
Do not display svn cross reference in private projects d2a45ea833
Display committer date instead of author date 16a35e7b5f
Remove dependency on GitPHP\Commit for CrossReferenceGitEnhancer 5746dbd03c
Collect commits contributor users in 1 query instead of n 4c8444e6b2

Follow-ups

User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes