Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #20977 Pull Request: equalizing sides is not useful if one side does not have content
    Actions
    Infos
    #20977
    Lorentz Romain (lorentzr)
    2021-04-30 10:42
    2021-04-29 14:59
    22578
    Details
    Pull Request: equalizing sides is not useful if one side does not have content

    On pull request changes tabs, when we add the first new comment, this will equalize sides even if one is empty. It can be strange because it make a round trip to the side or is put the commentary.

    2218-PullRequests.gif

    Pull Request
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Lorentz Romain (lorentzr)
    Closed
    2021-04-30
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #20930 Tuleap Releases 12.9 Delivered 2021-05-26 15:55 Manuel Vacelet (vaceletm)
    By Lorentz Romain (lorentzr)
    (782 kB)
    PullRequests.gif
    References
    Referencing request #20977

    Git commit

    tuleap/tuleap/stable

    Merge 'gerrit #22570' into stable/master de23159eef
    User avatar Thomas Gerbet (tgerbet) , 2021-04-30 08:15
    request #20977 Pull Request: equalizing sides is not useful if one side does not have content f8fc15270b
    User avatar Lorentz Romain (lorentzr) , 2021-04-29 17:16
    Referenced by request #20977

    Artifact Tracker v5

    rel #20930 12.9

    Other

    gerrit #22570
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2021-04-30 10:42

    Integrated into Tuleap 12.8.99.7.

    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2021-04-30
    User avatar
    Lorentz Romain (lorentzr)2021-04-29 17:15
    • Summary
      -Pull Request: equalize sides is not usefull if their is no text on one side 
      +Pull Request: equalizing sides is not useful if one side does not have content 
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes