•  
     
    story #21418 close artifacts with Done semantic
Summary
Empty
close artifacts with Done semantic
Empty

Overview

This story is a follow-up of art #17183. It fine tune the behaviours

Done semantic

As of art #17183, when artifacts are closed by a commit made on GitLab Tuleap will pick the first "Non open" value (as per "Status" semantic).

When there are several closed values, it might not be the best choice (for instance if the first value is "Canceled").

There is a "Done" semantic that should be used for that but this semantic is provided by Agile Dashboard. Hence:

  • Done semantic should be moved to Tracker for broader re-use
  • GitLab integration should use Done semantic

Keywords

The pattern to close should be widen to match GitLab patterns:

  • Close, Closes, Closed, Closing, close, closes, closed, closing
  • Fix, Fixes, Fixed, Fixing, fix, fixes, fixed, fixing
  • Resolve, Resolves, Resolved, Resolving, resolve, resolves, resolved, resolving
  • Implement, Implements, Implemented, Implementing, implement, implements, implemented, implementing

The keyword can be in title or description of commits or merge requests.

Restrict when to close

As per GitLab documentation, the attempt to automatically close

[...] happens when the commit is pushed to a project’s default branch, or when a commit or merge request is merged into it.

Empty
Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#21418
Manuel Vacelet (vaceletm)
2021-06-23 11:42
2021-05-27 17:16
3747

References
Referencing story #21418

Follow-ups

User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes