Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #22588 Drop manual assertions after calling EventDispatcherInterface::dispatch
    Actions
    Infos
    #22588
    Thomas Gerbet (tgerbet)
    2021-08-03 17:05
    2021-07-30 10:09
    24158
    Details
    Drop manual assertions after calling EventDispatcherInterface::dispatch

    In order to have autocompletion/static analysis we often have added an assert() after a call to EventDispatcherInterface::dispatch.

    For the static analysis part, Psalm does not need it anymore, we introduced a stub for it a while ago.

    For the IDE autocompletion, we can hint Jetbrains tools what's the actual type of the returned value by defining a specific override in a .phpstorm.meta.php file.

    Dev tools
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2021-08-03
    Attachments
    Empty
    References
    Referencing request #22588

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/58/23558/2' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD c7b82917c7
    User avatar Benjamin Bouillot (ben.bouillot) , 2021-08-03 17:05
    request #22588: Drop manual assertions after calling EventDispatcherInterface::dispatch e9a446c706
    User avatar Thomas Gerbet (tgerbet) , 2021-07-30 10:45
    Referenced by request #22588

    Artifact Tracker v5

    rel #20933 12.12

    Other

    gerrit #23558
    Display settings

    Follow-ups