•  
      request #27883 Merging a pull request does not close referenced artifacts
    Infos
    #27883
    Joris MASSON (jmasson)
    2022-08-26 16:35
    2022-07-21 16:31
    29305
    Details
    Merging a pull request does not close referenced artifacts

    Given I have pushed commits with "closing references" such as Closes art #000 on a pull request branch, when I click on "merge" on the web interface then the artifacts I referenced in the commit messages are not closed (or sometimes they are but in specific conditions).

    The root cause is that the code that closes these artifacts finds the username doing the push and assumes it is a valid Tuleap user. In the case of a pull request merge, it turns out that the push is made as a technical user (gitolite) that has no matching user account on Tuleap-side. Tuleap therefore builds an "anonymous" user account for it. This user is then the basis for all other checks, such as verifying access to the Tuleap project, verifying access to the referenced artifact, etc.

    Thus, on platforms allowing anonymous users, on public projects, when the artifact is accessible to anonymous, it works and the resulting comment references a username @ with nothing else after. In all other cases, it will do nothing (the artifacts won't be closed).

    Empty
    13.11
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2022-08-26
    Attachments
    Empty
    References
    Referencing request #27883

    Follow-ups