Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #31113 Simplify hook listening for plugins
    Actions
    Infos
    #31113
    Manuel Vacelet (vaceletm)
    2023-04-05 10:32
    2023-03-03 12:07
    32748
    Details
    Simplify hook listening for plugins

    As of today, for plugins, listening to hooks is tedious, there is a lot of copy/paste and things are scattered at different places:

    • Usage of hooks must be declared in getHooksAndCallbacks
    • It's not easy to find the hook that correspond to a callback
    • There is a lot of repetition of the event: at hook declaration (getHooksAndCallbacks), at the name of the callback, at the first parameter name.

    Using attributes, we can greatly simplify that.

    Empty
    Empty
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Manuel Vacelet (vaceletm)
    Closed
    2023-03-30
    Attachments
    Empty
    References
    Referencing request #31113

    Artifact Tracker v5

    request #31547 Simplify hook listening for plugins Part 2

    Git commit

    tuleap/tuleap/stable

    chore: Hooks can be listened to with Attributes 64be87d14c
    User avatar Manuel Vacelet (vaceletm) , 2023-03-06 17:17
    chore: Plugin::addHook is now deprecated 89d610212b
    User avatar Nicolas Terray (nterray) , 2023-03-07 15:43
    chore: Deal with conditional event listening 62ae8e63a2
    User avatar Manuel Vacelet (vaceletm) , 2023-03-08 09:32
    chore: Remove addHook usage where $recall_hook is true 02611be7ce
    User avatar Nicolas Terray (nterray) , 2023-03-10 10:12
    chore: remove $recall_hook parameter from addHook bbc792da31
    User avatar Nicolas Terray (nterray) , 2023-03-10 10:34
    chore: Convert SvnPlugin to attribute based hook listening 9373249683
    User avatar Manuel Vacelet (vaceletm) , 2023-03-10 11:43
    chore: Convert DocmanPlugin to attribute based event listening 208eb3df2b
    User avatar Manuel Vacelet (vaceletm) , 2023-03-17 16:52
    chore: Convert some plugins to attribute based event listening 78546581ae
    User avatar Nicolas Terray (nterray) , 2023-03-20 10:30
    chore: Convert mediawiki_standalone to attribute based event listening c016a2fc36
    User avatar Nicolas Terray (nterray) , 2023-03-23 11:15
    chore: Convert FTS plugins to attribute based event listening 85644920b5
    User avatar Nicolas Terray (nterray) , 2023-03-23 11:35
    chore: Convert Roadmap plugin to attribute based event listening 6091655692
    User avatar Nicolas Terray (nterray) , 2023-03-27 16:29
    chore: Convert Baseline plugin to attribute based event listening 93e5a5fad8
    User avatar Nicolas Terray (nterray) , 2023-03-27 16:37
    chore: Convert project_ownership plugin to attribute based event listening 27d9d7fdc7
    User avatar Nicolas Terray (nterray) , 2023-03-27 17:55
    chore: Convert oauth2_server plugin to attribute based event listening 323768dad4
    User avatar Nicolas Terray (nterray) , 2023-03-27 17:59
    chore: Convert create_test_env plugin to attribute based event listening 07d68e2d61
    User avatar Nicolas Terray (nterray) , 2023-03-28 15:17
    chore: Convert onlyofficePlugin to attribute based event listening dc615467fb
    User avatar Nicolas Terray (nterray) , 2023-03-27 16:42
    chore: Remove constant based events from tracker plugin 16b3f18c32
    User avatar Nicolas Terray (nterray) , 2023-03-27 16:16
    Convert projectmilestones to attribute based event listening 39147dd291
    User avatar Nicolas Terray (nterray) , 2023-04-04 15:41
    Display settings

    Follow-ups

    User avatar
    Manuel Vacelet (vaceletm)2023-03-30 12:26

    All open changes related to that topic were merged, let's closed this artifact. We will open dedicated artifacts for future conversions.

    • Status changed from Under implementation to Closed
    • Connected artifacts
    • Close date set to 2023-03-30