Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #35473 Stop relying on the god PullRequest/Factory class to retrieve pull request
    Actions
    Infos
    #35473
    Clarck Robinson (robinsoc)
    2023-12-13 14:50
    2023-12-11 16:01
    37113
    Details
    Stop relying on the god PullRequest/Factory class to retrieve pull request

    During the release 15.2 and 15.3, we have implemented a dedicated object (PullRequestRetriever) to retrieve a pull request by its id. We did not depend on the god class PullRequest/Factory to retrieve a pull request by its id.

    Bonus: it is also the opportunity to use Neverthrow to handle the case when there is no pull request returned by the DB

    Pull Request
    15.3
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Clarck Robinson (robinsoc)
    Closed
    2023-12-13
    Attachments
    Empty
    References
    Referencing request #35473

    Git commit

    tuleap/tuleap/stable

    refactor: Stop relying on the the god PullRequest/Factory class in CrossReferencePullRequestOrganizer.php 533475cb69
    User avatar Clarck Robinson (robinsoc) , 2023-12-11 16:47
    refactor: Stop relying on the the god PullRequest/Factory class in ReferenceFactory.php 2805142485
    User avatar Clarck Robinson (robinsoc) , 2023-12-11 16:57
    refactor: Stop relying on the the god PullRequest/Factory class in reviewer part f040a7afb8
    User avatar Clarck Robinson (robinsoc) , 2023-12-11 16:57
    refactor: Stop relying on the the god PullRequest/Factory class when the d66161d370
    User avatar Clarck Robinson (robinsoc) , 2023-12-13 11:20
    Display settings

    Follow-ups

    User avatar
    Joris MASSON (jmasson)2023-12-13 14:50

    gerrit #29965 (when the PR status change) integrated in Tuleap 15.3.99.38

    • Status changed from Under implementation to Closed
    • Connected artifacts
    • Close date set to 2023-12-13
    User avatar
    Clarck Robinson (robinsoc)2023-12-11 16:47
    • Summary
      -Stop relying on the the god PullRequest/Factory class 
      +Stop relying on the god PullRequest/Factory class to retrieve pull request 
    User avatar
    Clarck Robinson (robinsoc)2023-12-11 16:06
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes