•  
      request #35843 Login page crashes when a null byte is set in the return_to parameter
    Infos
    #35843
    Thomas Gerbet (tgerbet)
    2024-01-15 14:17
    2024-01-11 11:15
    37445
    Details
    Login page crashes when a null byte is set in the return_to parameter

    To reproduce: GET /account/login.php?return_to=%00

    Trace:

    PHP message: PHP Fatal error:  Uncaught TypeError: Tuleap\User\AdditionalConnectorsCollector::__construct(): Argument #1 ($return_to) must be of type string, null given, called in /usr/share/tuleap/src/common/User/LoginPresenterBuilder.php on line 34 and defined in /usr/share/tuleap/src/common/User/AdditionalConnectorsCollector.php:34
    Stack trace:
    #0 /usr/share/tuleap/src/common/User/LoginPresenterBuilder.php(34): Tuleap\User\AdditionalConnectorsCollector->__construct()
    #1 /usr/share/tuleap/src/www/account/login.php(109): User_LoginPresenterBuilder->build()
    #2 {main}
      thrown in /usr/share/tuleap/src/common/User/AdditionalConnectorsCollector.php on line 34
    
    Other
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2024-01-15
    Attachments
    Empty
    References

    Follow-ups