request #37942 Wrong unit for disk usage statistics in export

Artifact

Infos

Artifact ID#37942

Submitted byGuilhem Bonnefille (CS) (gbonnefille)

Last Modified On2024-05-14 14:28

Submitted on2024-05-13 15:11

Rank39566

Details

Summary *

Wrong unit for disk usage statistics in export

Original Submission

When exporting statistics (https://tuleap.net/plugins/statistics/data_export.php) two columns states data as MB:

Disk usage at start date (MB)
Disk usage at end date (MB)

But the computation is wrong. In the code (plugins/statistics/include/Statistics_Services_UsageFormatter.class.php:26) we read:

    /** @const number of bytes in a MegaByte */
    public const BYTES_NUMBER_IN_MB = 1000;

This is wrong: MB = 1000*kB = 1000*1000*B

CategorySite admin

Reported in versionAll

PlatformEmpty

Is an Enhancement or an internal improvement?

[ ] enhancement
[ ] internal improvement

CC listEmpty

Stage

Assigned toEmpty

StatusClosed

Close date2024-05-14

Attachments

Connected artifacts

Artifact links

Releases

Fixed in

	Artifact ID	Project	Tracker	Summary	Status	Last Update Date	Submitted By	Assigned to
	rel #36798	Tuleap	Releases	15.9	Delivered	2024-05-27 10:36	Manuel Vacelet (vaceletm)

Reverse artifact links

Empty

AttachmentsEmpty

References

Cross references

Referencing request #37942

Git commit

tuleap/tuleap/stable

fix(statistics): express disk usage as bytes bf3a1a7c82

Guilhem Bonnefille , 2024-05-14 13:28

Show items referenced by request #37942

Referenced by request #37942

Artifact Tracker v5

rel #36798 15.9

Follow-ups

Joris MASSON (jmasson)

2024-05-14 14:28

Status changed from New to Closed
Connected artifacts
- Added Fixed in: rel #36798
Close date set to 2024-05-14

Manuel Vacelet (vaceletm)

2024-05-13 16:14

For reference, discussion about the choice: https://chat.tuleap.org/channel/general?msg=2DyAR7fXopNWH8zwH

Summary: let's go for bytes (instead of current computation), this way the admin can do it's own compute (MB, MiB, GB, GiB, etc). The change will be big enough (x1000 on the value) so recurring usage of this export will notice the increase due to the fix.

Guilhem Bonnefille (CS) (gbonnefille)

2024-05-13 15:45

last edited by: Guilhem Bonnefille (CS) (gbonnefille)

2024-05-13 15:46

Patch submitted on https://gerrit.tuleap.net/c/tuleap/+/31070

Public