•  
      request #43347 Do not crash when trying to access raw file content with invalid parameters
    Infos
    #43347
    Thomas Gerbet (tgerbet)
    2025-06-10 15:57
    2025-06-09 16:04
    45029
    Details
    Do not crash when trying to access raw file content with invalid parameters

    Reproduction scenario:

    1. Go to /plugins/git/<project_name>/a?a=blob_plain&noheader=1 where project name exists

    Trace:

    Fatal error: Uncaught Error: Call to a member function SetPath() on null in /usr/share/tuleap/plugins/git/include/GitPHP/controller/Controller_Blob.php:133
    Stack trace:
    #0 /usr/share/tuleap/plugins/git/include/GitPHP/controller/ControllerBase.php(247): Tuleap\Git\GitPHP\Controller_Blob->LoadHeaders()
    #1 /usr/share/tuleap/plugins/git/include/GitViews/GitPhpViewer.php(94): Tuleap\Git\GitPHP\ControllerBase->RenderHeaders()
    #2 /usr/share/tuleap/plugins/git/include/GitViews/GitPhpViewer.php(77): GitViews_GitPhpViewer->displayGitPHP()
    #3 /usr/share/tuleap/plugins/git/include/Git/GitRepositoryBrowserController.php(123): GitViews_GitPhpViewer->displayContentWithoutEnclosingDiv()
    #4 /usr/share/tuleap/src/common/Request/FrontRouter.php(251): Tuleap\Git\GitRepositoryBrowserController->process()
    #5 /usr/share/tuleap/src/common/Request/FrontRouter.php(109): Tuleap\Request\FrontRouter->routeHandler()
    #6 /usr/share/tuleap/src/www/index.php(50): Tuleap\Request\FrontRouter->route()
    #7 {main} thrown in /usr/share/tuleap/plugins/git/include/GitPHP/controller/Controller_Blob.php on line 133
    
    SCM/Git
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2025-06-10
    Attachments
    Empty
    References

    Follow-ups