Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #9793 Import vendor CSS files without renaming
    Actions
    Infos
    #9793
    Joris MASSON (jmasson)
    2017-09-20 16:29
    2017-01-02 17:53
    10067
    Details
    Import vendor CSS files without renaming
    Previously, we used a version of libsass that did not permit importing CSS files inline. It only allowed 'CSS @import' or importing SCSS files inline. So, we used a build step to rename vendor "filename.css" files to "_.<filename>.scss", that would enable us to import them.

    Now, thanks to https://github.com/sass/libsass/pull/754 it is possible to directly import regular CSS files inline and so we should remove our now unnecessary build steps.
    Other
    All
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Joris MASSON (jmasson3)
    Closed
    2017-09-20
    Attachments
    Empty
    References
    Referencing request #9793

    Git commit

    tuleap/tuleap/stable

    Import vendor CSS files without renaming in gulpfiles 8b7f901842
    User avatar Joris MASSON (jmasson) , 2017-01-02 17:53
    Use node-sass instead of ruby sass 2995030c71
    User avatar Joris MASSON (jmasson) , 2017-01-26 17:49
    Import vendor CSS files without renaming in kanban 090e5399ab
    User avatar Joris MASSON (jmasson) , 2017-01-26 15:45
    Import vendor CSS files without renaming in planning v2 f30fcee0d5
    User avatar Joris MASSON (jmasson) , 2017-01-26 15:44
    Import vendor CSS files without renaming in Trafficlights f6431462a8
    User avatar Joris MASSON (jmasson) , 2017-01-27 17:04
    Display settings

    Follow-ups

    User avatar
    Joris MASSON (jmasson)2017-09-20 16:29
    gerrit #9528 integrated into Tuleap 9.12.99.6 and is the last commit needed
    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2017-09-20
    User avatar
    Joris MASSON (jmasson)2017-04-25 12:37
    gerrit #8279 is in review for the pullrequest plugin
    The angular artifact modal (modal v3) does not include its Sass dependencies for some reason, which means it won't need to be modified.
    User avatar
    Joris MASSON (jmasson)2017-02-07 14:09
    The PullRequest plugin and the angular artifact modal (modal v3) remain to be modified.
    User avatar
    Joris MASSON (jmasson)2017-01-25 15:04
    I think we should wait for angular apps update. I have a patch for kanban incoming