Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #22204 ForgeUpgrade should exit with an error exit code on failure
    Infos
    #22204
    Thomas Gerbet (tgerbet)
    2021-07-08 10:03
    2021-07-07 09:15
    23781
    Details
    ForgeUpgrade should exit with an error exit code on failure

    When a bucket cannot be applied, ForgeUpgrade should exit with a exit code different than 0 to signal the issue. Currently when you execute it in automated way (Docker images, Ansible deployments...) an error is easy to miss and you cannot stop on failure.

    Docker images
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2021-07-08
    Attachments
    Empty
    References
    Referencing request #22204

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/32/23332/1' of ssh://gerrit.tuleap.net:29418/tuleap 1493d5def0
    User avatar Manuel Vacelet (vaceletm) , 2021-07-07 21:58
    request #22204: ForgeUpgrade should exit with an error exit code on failure 44629fecd2
    User avatar Thomas Gerbet (tgerbet) , 2021-07-07 10:47
    Referenced by request #22204

    Artifact

    rel #20932 12.11

    Other

    gerrit #23332
    Display settings

    Follow-ups

    User avatar
    Manuel Vacelet (vaceletm)2021-07-08 10:03

    Not exactly sure to see what you have in mind, we are a bit forced to run the migrations in order since some implicit dependencies might exist between them no?

    Sorry, I miss read the code, I was looking at the "force" part and thought it was not wise to continue the bucket execution. But as it's force...

    • Status changed from Under review to Closed
    • Close date set to 2021-07-08
    User avatar
    Thomas Gerbet (tgerbet)2021-07-08 09:59

    Shouldn't we change the evaluation strategy and have a fail fast approach to avoid queuing mess on top of a pile of poo ?

    Not exactly sure to see what you have in mind, we are a bit forced to run the migrations in order since some implicit dependencies might exist between them no?

    User avatar
    Manuel Vacelet (vaceletm)2021-07-07 21:59

    gerrit #23332 integrated in Tuleap 12.10.99.111

    Shouldn't we change the evaluation strategy and have a fail fast approach to avoid queuing mess on top of a pile of poo ?

    User avatar
    Thomas Gerbet (tgerbet)2021-07-07 10:49

    See gerrit #23332.

    • Summary
      -ForgeUpgrade should exist with an error exit code on failure 
      +ForgeUpgrade should exit with an error exit code on failure 
    • Status changed from Verified to Under review