Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #26383 Stylelint should not check every file in pre-commit hook
    Actions
    Infos
    #26383
    Joris MASSON (jmasson)
    2022-04-08 16:48
    2022-04-08 16:14
    27907
    Details
    Stylelint should not check every file in pre-commit hook

    Following git #tuleap/stable/89c38120f462dee708bff0c2f17b09a4309058ee, the npm script used for stylelint was committed with fixed globs to look for vue and scss files. However in the case of pre-commit hooks, it means it will check every file instead of just the modified ones, thus slowing down tremendously the time to commit. We should revert this change.

    Dev tools
    development
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Joris MASSON (jmasson)
    Closed
    2022-04-08
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #25363 Tuleap Releases 13.8 Delivered 2022-02-05 09:52 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #26383

    Git commit

    tuleap/tuleap/stable

    Merge 'gerrit #25627' into stable/master ebac2027a5
    User avatar Thomas Gerbet (tgerbet) , 2022-04-08 16:47
    request #26383 Stylelint should not check every file in pre-commit hook aa7baea55b
    User avatar Joris MASSON (jmasson) , 2022-04-08 16:16
    Referenced by request #26383

    Artifact Tracker v5

    rel #25363 13.8

    Git commit

    tuleap/tuleap/stable

    stylelint 14.2.0 -> 14.6.1 89c38120f4
    User avatar Joris MASSON (jmasson) , 2022-04-05 10:15

    Other

    gerrit #25627
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2022-04-08 16:48

    Integrated into Tuleap 13.7.99.114.

    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2022-04-08