Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #10427 Use expected temporary directory when trying to merge a pull request
    Actions
    Infos
    #10427
    Thomas Gerbet (tgerbet)
    2017-07-10 10:28
    2017-07-07 17:00
    10668
    Details
    Use expected temporary directory when trying to merge a pull request
    Currently when the pull request plugin tries to do a merge it does it in a folder under /var/lib/tuleap/gitolite/repositories/.

    The directories are temporary working directories and they should probably treated as such. Also, using a directory under /var/lib/tuleap/gitolite/repositories/ can cause issues, it seems that under some (not yet determined) conditions the created directory can become owned by the gitolite user instead of the initial codendiadm user which will block future merges with this error:
    This Pull Request cannot be merged: Command execution failure: /opt/rh/git19/root/usr/bin/git --work-tree='' --git-dir='/.git' fetch '/var/lib/tuleap/gitolite/repositories/test/PR_Test.git' 'refs/heads/feature/test-ss' (return value: 128):
    fatal: Not a git repository: '/.git'
    Pull Request
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2017-07-10
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #10352 Tuleap Releases 9.10 Delivered 2017-07-12 17:14 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #10427

    Git commit

    tuleap/tuleap/stable

    request #10427: Use expected temporary directory when trying to merge a pull request 2c4d72119a
    User avatar Thomas Gerbet (tgerbet) , 2017-07-07 17:22
    Referenced by request #10427

    Artifact Tracker v5

    rel #10352 9.10

    Other

    gerrit #8939
    Display settings

    Follow-ups

    User avatar
    Yannis ROSSETTO (rossettoy)2017-07-10 10:28
    Integrated into pullrequest code base.
    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2017-07-10