•  
      request #10760 generate-po should never been forgotten
    Infos
    #10760
    Marie Ange Garnier (marieange)
    2018-02-26 11:27
    2017-10-19 17:18
    10929
    Details
    generate-po should never been forgotten
    We should add tests which fails if a contributor has forgotten to generate PO files in his contribution.
    Other
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2018-02-26
    Attachments
    Empty
    References

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2018-02-23 16:57
    The first part for fixing this issue is available for review: pr #68, once this merged I will adapt the test pipeline to fail contributions with translations not updated.
    User avatar
    Thomas Gerbet (tgerbet)2018-02-23 16:35
    I have splitted this request, see request #11185 for the discussion about autoloads generation. This request will only concern PO files used by gettext.

    Due to the regular omission of the update of the PO files, I'm going to deal with it.

    • Summary
      -Autoload and generate-po should never been forgotten 
      +generate-po should never been forgotten 
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from New to Under implementation
    User avatar
    poedit is not involved during the call of `make generate-po`.

    About the dedicated job, i'm not sure. I think that having stuff only in CI prevent us to run it on our side ot to version control it. Can it be in the Jenkinsfile?
    User avatar
    IMHO, I would prefer having a job in the CI as done for the lockfiles.

    However, to do this, we have to fix the version of some tools (poedit for instance) to do this.