•  
      request #11175 Remove iframe in continuous integration
    Infos
    #11175
    Nicolas Terray (nterray)
    2018-02-26 10:37
    2018-02-21 13:57
    11448
    Details
    Remove iframe in continuous integration
    By default, Jenkins disallows[1] display in iframe in order to prevent clickjacking attacks[2]. Therefore, instead of displaying a blank iframe that looks like broken, we should remove it instead.

    This means that on Continuous Integration service homepage, there isn't any iframe displayed when you click on a job or its builds.

    In widgets, or in case of direct link to a CI items through cross references:
    - job #valid_sample_job target page should display a link to the job instead of an iframe
    - build #123 target page should display a link to the build instead of an iframe

    [1] https://github.com/jenkinsci/jenkins/commit/16931bd7bf7560e26ef98328b8e95e803d0e90f6
    [2] https://tools.ietf.org/html/rfc7034
    Empty
    All
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Empty
    Closed
    2018-02-22
    Attachments
    Empty
    References
    Referencing request #11175
    Referenced by request #11175

    Artifact Tracker v5

    rel #10968 9.18

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2018-02-22 09:00
    Integrated into Tuleap 9.17.99.166.

    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2018-02-22