Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #11667 display diff side by side
Actions
Summary
Empty
display diff side by side
Empty

Functional overview

  • In the "file" view, there is a new toggle to display diff either in side-by-side or in unidiff.
  • When diff is changed, the preference for user is kept and will be used by default (user can change at any time).
  • Default is still unidiff

The diff is then displayed side by side and all features of diff works the same (comment & co).

Technical overview

  • CSS will be tricky to be right and efficient (esp. big files). Should be done on top of burning parrot pages
  • Most of the work is front end (angular). REST backend isn't supposed to change
  • Point of attention
    • Storage of comments (should be ok as we already store the offset)
    • Autocollapse of common diff parts
    • Scroll synchro should be managed manually
    • Code need to be prepared to introduce side-by-side
    • Bump of CodeMirror to latest version
Empty
Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#11667
Manuel Vacelet (vaceletm)
2018-12-13 11:45
2018-06-22 15:06
12837

References
Artifact links
Empty
Referencing story #11667

Artifact Tracker v5

epic #11662 Pull requests
rel #11901 10.5

Git commit

tuleap/tuleap/stable

Add the Diff toggle button and store user preference ee3556483c
User avatar Thomas Gorka (tgorka) , 2018-08-31 08:53
Refactoring: Diff directive clean-up 76f50e25e6
User avatar Joris MASSON (jmasson) , 2018-08-31 11:45
Refactoring: have two dedicated diff components dac1256c76
User avatar Joris MASSON (jmasson) , 2018-08-31 16:15
Display code in side-by-side diff ebe74403e7
User avatar Joris MASSON (jmasson) , 2018-09-03 17:17
Synchronize scrolling with two diffs fde69b240f
User avatar Joris MASSON (jmasson) , 2018-09-05 14:26
Display comments in side-by-side diff 11a5eaccd2
User avatar Joris MASSON (jmasson) , 2018-09-05 17:09
Autocollapse common code sections for unified diff 5e6667d343
User avatar Thomas Gorka (tgorka) , 2018-09-06 15:11
Keep new comments in sync when switching diff mode d2c760f4b8
User avatar Joris MASSON (jmasson) , 2018-09-06 17:42
Have syntaxe colorization dcd753135d
User avatar Thomas Gorka (tgorka) , 2018-09-10 10:11
Autofocus the new inline comment textarea 36a24a71df
User avatar Thomas Gorka (tgorka) , 2018-09-07 15:20
Take wrapped lines into account for placeholders 28a3d79db0
User avatar Joris MASSON (jmasson) , 2018-09-11 14:14
Add comment in side-by-side diff 5e0ff23456
User avatar Joris MASSON (jmasson) , 2018-09-11 17:15
Add left or right position to inline_comment representation 7950ee848f
User avatar Thomas Gorka (tgorka) , 2018-09-21 13:07
Possibility to add inline-comments on left side for deleted lines 7cc4f37154
User avatar Thomas Gorka (tgorka) , 2018-09-24 10:45
Handle properly side by side comments 04f4260ce3
User avatar Thomas Gorka (tgorka) , 2018-10-01 09:58
Pull request diff design check 7d170445e7
User avatar Thomas Gorka (tgorka) , 2018-10-01 12:31
Collapse code properly when last line is commented 83371dbf52
User avatar Thomas Gorka (tgorka) , 2018-10-02 08:38
Display settings

Follow-ups

User avatar
Manuel Vacelet (vaceletm)2018-12-13 11:30

It means that the team had to write the javascript code to manage the synchronisation between the 2 views (left/right) when someones scroll in diff side by side

User avatar
Nicolas Terray (nterray)2018-08-31 10:55
gerrit #12510 integrated into Tuleap 10.4.99.127
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes