Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #11870 Work around npm bug modifying the lockfile when node_modules is present
    Actions
    Infos
    #11870
    Thomas Gerbet (tgerbet)
    2018-07-23 17:25
    2018-07-19 14:57
    12487
    Details
    Work around npm bug modifying the lockfile when node_modules is present
    So there is a bug in npm [0][1] affecting the targets "post-checkout" and "npm-build" of our helper Makefile.

    After being executed a first time these target will change the lockfile at the root of the Tuleap sources and if a Tuleap contributor try to commit it the CI (rightfully) rejects the contribution because the change in the lockfile is not needed.

    This behavior can confuse newcomers wanting to contribute, we should work around the issue until it is fixed upstream.


    [0] https://npm.community/t/package-lock-json-and-optional-packages/692
    [1] https://github.com/npm/npm/issues/17722
    Other
    Empty
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Empty
    Closed
    2018-07-23
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #11518 Tuleap Releases 10.4 Delivered 2018-08-20 13:51 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #11870

    Artifact Tracker v5

    request #11908 Make post-checkout throw error

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/90/12090/1' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 760adcf25d
    User avatar Marie Ange Garnier (marieange) , 2018-07-23 17:24
    request #11870: Work around npm bug modifying the lockfile when node_modules is present 0004178f05
    User avatar Thomas Gerbet (tgerbet) , 2018-07-19 15:03
    Referenced by request #11870

    Artifact Tracker v5

    rel #11518 10.4

    Other

    gerrit #12090
    Display settings

    Follow-ups