•  
      request #11886 Move Archivedeleteditems plugin tests to PHPUnit
    Infos
    #11886
    Yannis ROSSETTO (rossettoy)
    2018-07-26 11:17
    2018-07-21 12:09
    12501
    Details
    Move Archivedeleteditems plugin tests to PHPUnit
    Empty
    Empty
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2018-07-26
    Attachments
    Empty
    References

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2018-07-25 15:16
    Images used to run the tests did not have the php-process package installed. Images are rebuilding now, it should be better.

    Also while I was there I also took the opportunity to update the contribution to use vfsStream instead of creating real files that we need to clean up in the tests.
    User avatar
    A patch is in WIP state: gerrit #12116

    I'm stuck on the following error:

    PHP Fatal error: Call to undefined function posix_getpwuid() in /tuleap/plugins/archivedeleteditems/include/FileCopier.php on line 91
    PHP Stack trace:
    PHP 1. {main}() /tuleap/src/vendor/phpunit/phpunit/phpunit:0
    PHP 2. PHPUnit_TextUI_Command::main() /tuleap/src/vendor/phpunit/phpunit/phpunit:52
    PHP 3. PHPUnit_TextUI_Command->run() /tuleap/src/vendor/phpunit/phpunit/src/TextUI/Command.php:116
    PHP 4. PHPUnit_TextUI_TestRunner->doRun() /tuleap/src/vendor/phpunit/phpunit/src/TextUI/Command.php:186
    PHP 5. PHPUnit_Framework_TestSuite->run() /tuleap/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:517
    PHP 6. PHPUnit_Framework_TestSuite->run() /tuleap/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:733
    PHP 7. PHPUnit_Framework_TestSuite->run() /tuleap/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:733
    PHP 8. PHPUnit_Framework_TestCase->run() /tuleap/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:733
    PHP 9. PHPUnit_Framework_TestResult->run() /tuleap/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:868
    PHP 10. PHPUnit_Framework_TestCase->runBare() /tuleap/src/vendor/phpunit/phpunit/src/Framework/TestResult.php:686
    PHP 11. PHPUnit_Framework_TestCase->runTest() /tuleap/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:913
    PHP 12. ReflectionMethod->invokeArgs() /tuleap/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:1062
    PHP 13. Tuleap\ArchiveDeletedItems\FileCopierTest->testItDoesNotCopyIfDestinationFileExist() /tuleap/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:1062
    PHP 14. Tuleap\ArchiveDeletedItems\FileCopier->copy() /tuleap/plugins/archivedeleteditems/phpunit/FileCopierTest.php:70
    PHP 15. Tuleap\ArchiveDeletedItems\FileCopier->getGroupNameForFile() /tuleap/plugins/archivedeleteditems/include/FileCopier.php:45

    • Status changed from New to Under implementation