Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #12833 Reduce events that need to load all plugins
    Actions
    Infos
    #12833
    Manuel Vacelet (vaceletm)
    2019-02-27 14:21
    2019-01-25 14:37
    13677
    Details
    Reduce events that need to load all plugins

    As of today there are a couple of events that are present on a lot of pages/routes and that need to load almost all plugins.

    When there are a lot of plugins it becomes to be sensible in term of performance impact.

    As a matter of fact, on site home (/) without statistics or news, autoload reports almots 3000 class to load for *nothing*, just to be there.

    There are several candidates nominated:

    • CollectRoutesEvent. The event is relevant (cannot be removed) but routes should be cached to avoid fireing it on all pages

    Other
    Empty
    Empty
    • [x] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2019-02-27
    Attachments
    Artifact links
    Empty
    Empty
    References
    Referencing request #12833

    Git commit

    tuleap/tuleap/stable

    Front router should not rely on closure [intro] 20dd818b9b
    User avatar Manuel Vacelet (vaceletm) , 2019-01-25 14:38
    Remove usage of callback for route handlers in plugins dc49103b64
    User avatar Manuel Vacelet (vaceletm) , 2019-01-29 09:13
    Cache FrontRouter routes a4b038655e
    User avatar Manuel Vacelet (vaceletm) , 2019-01-29 17:07
    Referenced by request #12833

    Other

    gerrit #13626
    gerrit #13825
    gerrit #13847
    Display settings

    Follow-ups

    User avatar
    Manuel Vacelet (vaceletm)2019-02-27 14:21

    I close this one because the marginal gains expected are too narow to be really worth them.

    Moreover the big gains would be to get rid of url_verifications and to completely rewrite the way services, icons & co are managed between core and plugins.

    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from Under implementation to Closed
    • Close date set to 2019-02-27
    User avatar
    Thomas Gerbet (tgerbet)2019-01-25 16:52
    The introductory contribution gerrit #13626 has been merged into Tuleap 10.9.99.174.

    Once we are done with the changes we need to think about updating the dev guide.