Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #12835 Downloading a LFS file via the web UI download URL on a deleted repository crashes
    Actions
    Infos
    #12835
    Thomas Gerbet (tgerbet)
    2019-03-05 10:00
    2019-01-25 16:33
    13682
    Details
    Downloading a LFS file via the web UI download URL on a deleted repository crashes
    Git LFS objects can be downloaded in the web UI via a dedicated link.

    If you share this link and the repository is deleted, a fatal error will be generated.

    The error should be gracefully handled and a PHP fatal error should not be generated.


    Trace:
    ( ! ) Fatal error: Uncaught Error: Call to a member function userCanRead() on null in /usr/share/tuleap/plugins/gitlfs/include/Download/FileDownloaderController.php on line 92
    ( ! ) Error: Call to a member function userCanRead() on null in /usr/share/tuleap/plugins/gitlfs/include/Download/FileDownloaderController.php on line 92
    Call Stack
    # Time Memory Function Location
    1 0.0049 399192 {main}( ) .../index.php:0
    2 0.0542 2481352 Tuleap\Request\FrontRouter->route( ??? ) .../index.php:45
    3 0.1165 5873432 Tuleap\GitLFS\Download\FileDownloaderController->process( ???, ???, ??? ) .../FrontRouter.php:106
    SCM/Git
    10.9
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2019-03-05
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #12561 Tuleap Releases 11.0 Delivered 2019-04-07 00:54 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #12835

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/99/13799/3' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 17ca127552
    User avatar Yannis ROSSETTO (rossettoy) , 2019-03-05 09:58
    request #12835: Downloading a LFS file via the web UI download URL on a deleted repository crashes 283e4af0a1
    User avatar Thomas Gerbet (tgerbet) , 2019-02-26 09:03
    Referenced by request #12835

    Artifact Tracker v5

    rel #12561 11.0

    Other

    gerrit #12835
    Display settings

    Follow-ups

    User avatar
    Yannis ROSSETTO (rossettoy)2019-03-05 10:00
    Integrated into Tuleap 10.11.99.41
    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2019-03-05