Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #13391 Sending a mail notification can crash if the project is private and the notification is sent by a non web process
    Actions
    Infos
    #13391
    Thomas Gerbet (tgerbet)
    2019-05-20 16:43
    2019-05-20 13:08
    14511
    Details
    Sending a mail notification can crash if the project is private and the notification is sent by a non web process
    Sending mail notification can crash the backend process and prevent the notification to be sent.

    Issue is likely to have been introduced by the changes done in story #12554.


    Trace with a tracker notification and the backend notification mechanism:
    info Start service
    info Wait for messages
    info Got message: {"event_name":"tuleap.tracker.artifact","payload":{"artifact_id":503516,"changeset_id":1016804}}
    PHP Notice: Undefined index: REQUEST_URI in /usr/share/tuleap/src/common/include/URLVerification.class.php on line 450
    PHP Fatal error: Uncaught TypeError: Argument 3 passed to Tuleap\Project\RestrictedUserCanAccessUrlOrProjectVerifier::__construct() must be of the type string, null given, called in /usr/share/tuleap/src/common/include/URLVerification.class.php on line 450 and defined in /usr/share/tuleap/src/common/Project/RestrictedUserCanAccessUrlOrProjectVerifier.php:47
    Stack trace:
    #0 /usr/share/tuleap/src/common/include/URLVerification.class.php(450): Tuleap\Project\RestrictedUserCanAccessUrlOrProjectVerifier->__construct(Object(EventManager), Object(URL), NULL)
    #1 /usr/share/tuleap/src/common/mail/MailFilter.php(83): URLVerification->userCanAccessProject(Object(PFUser), Object(Project))
    #2 /usr/share/tuleap/src/common/mail/MailBuilder.php(56): Tuleap\Mail\MailFilter->filter(Object(Project), Array)
    #3 /usr/share/tuleap/src/common/mail/MailNotificationBuilder.php(64): MailBuilder->buildAndSendEmail(Object(Project), Object(Notification), Object(MailEnhancer))
    #4 /usr/share/tuleap/plugins/tracker/include/Tracker/Artifact/Changeset/PostCrea in /usr/share/tuleap/src/common/Project/RestrictedUserCanAccessUrlOrProjectVerifier.php on line 47
    Other
    11.0
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2019-05-20
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #13072 Tuleap Releases 11.2 Delivered 2019-05-29 16:32 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #13391

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/04/15004/2' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 7650f72753
    User avatar Joris MASSON (jmasson) , 2019-05-20 16:32
    request #13391: Sending a mail notification can crash if the project is private and the notification is sent by a non web process 518b85dd17
    User avatar Thomas Gerbet (tgerbet) , 2019-05-20 15:34
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2019-05-20 15:35
    • Summary
      -Sending a mail notification can crash if the project is public and the notification is sent by a non web process 
      +Sending a mail notification can crash if the project is private and the notification is sent by a non web process 
    User avatar
    Thomas Gerbet (tgerbet)2019-05-20 14:28
    Fix is under review here: gerrit #15004.
    • Summary
      -Sending a mail notification can crash if the project is public and the notifcation is sent by a backend process 
      +Sending a mail notification can crash if the project is public and the notification is sent by a non web process 
    • Status changed from Under implementation to Under review
    User avatar
    Thomas Gerbet (tgerbet)2019-05-20 13:50
    Updating original submission. All type of notifications can be affected by the issue as long as they are processed by any sort of backend process.
    • Summary
      -Sending tracker notification with the backend mechanism can crash if the project is public 
      +Sending a mail notification can crash if the project is public and the notifcation is sent by a backend process 
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Category changed from Trackers to Other