•  
      request #13829 Service.class::getFontAwesomeIcon should be protected
    Infos
    #13829
    Thomas Gorka (tgorka)
    2019-09-04 11:51
    2019-08-30 15:16
    15039
    Details
    Service.class::getFontAwesomeIcon should be protected
    TestManagement calls the private member function getFontAwesomeIcon of the Service class.


    ( ! ) Fatal error: Uncaught Error: Call to private method Service::getFontAwesomeIcon() from context 'Tuleap\TestManagement\Service' in /usr/share/tuleap/plugins/testmanagement/include/TestManagement/Service.class.php on line 51
    ( ! ) Error: Call to private method Service::getFontAwesomeIcon() from context 'Tuleap\TestManagement\Service' in /usr/share/tuleap/plugins/testmanagement/include/TestManagement/Service.class.php on line 51
    Call Stack
    # Time Memory Function Location
    1 0.0000 402320 {main}( ) .../index.php:0
    2 0.0142 2417440 Tuleap\Request\FrontRouter->route( ) .../index.php:46
    3 0.0146 2487408 Tuleap\Request\FrontRouter->routeHandler( ) .../FrontRouter.php:89
    4 0.0299 3195872 Tuleap\Project\Home->process( ) .../FrontRouter.php:232
    5 0.0495 3931640 Tuleap\Dashboard\Project\ProjectDashboardRouter->route( ) .../Home.php:142
    6 0.0495 3931640 Tuleap\Dashboard\Project\ProjectDashboardController->display( ) .../ProjectDashboardRouter.php:83
    7 0.0511 3951064 site_project_header( ) .../ProjectDashboardController.php:157
    8 0.0512 3951088 site_header( ) .../html.php:611
    9 0.0517 3964360 Tuleap\Theme\BurningParrot\BurningParrotTheme->header( ) .../html.php:559
    10 0.0521 3972048 Tuleap\Theme\BurningParrot\BurningParrotTheme->getSidebarFromParams( ) .../BurningParrotTheme.php:102
    11 0.0521 3972048 Tuleap\Theme\BurningParrot\BurningParrotTheme->getSidebarPresenterForProject( ) .../BurningParrotTheme.php:250
    12 0.0641 4349768 MustacheRenderer->renderToString( ) .../BurningParrotTheme.php:267
    13 0.0641 4349768 Tuleap\Templating\Mustache\MustacheEngine->render( ) .../MustacheRenderer.class.php:65
    14 0.0648 4377576 __Mustache_4deae8735bba3dc2a6b627d2835feb24->render( ) .../Engine.php:244
    15 0.0650 4379080 __Mustache_4deae8735bba3dc2a6b627d2835feb24->renderInternal( ) .../Template.php:72
    16 0.0652 4380376 __Mustache_4deae8735bba3dc2a6b627d2835feb24->sectionAc3831f07ac45a34101bd432bc426284( ) .../__Mustache_4deae8735bba3dc2a6b627d2835feb24.php:78
    17 0.0673 4451640 Tuleap\Layout\ProjectSidebarBuilder->getSidebar( ) .../__Mustache_4deae8735bba3dc2a6b627d2835feb24.php:503
    18 0.0680 4452184 Tuleap\TestManagement\Service->getIcon( ) .../ProjectSidebarBuilder.php:94
    Empty
    development
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gorka (tgorka)
    Declined
    2019-09-04
    Attachments
    Empty
    References
    Referenced by request #13829

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2019-09-04 11:51
    gerrit #15993 has been abandonned, change was not needed and the issue was actually already fixed.

    • Status changed from Under implementation to Declined
    • Close date set to 2019-09-04